mcvsubbu commented on a change in pull request #6331:
URL: https://github.com/apache/incubator-pinot/pull/6331#discussion_r540366317
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -2573,6 +2577,13 @@ private void waitForSegmentsBecomeOnline(String
tableNameWithType, Set<String> s
return onlineSegments;
}
+ public TableStats getTableStats(String tableNameWithType) {
+ String zkPath =
ZKMetadataProvider.constructPropertyStorePathForResourceConfig(tableNameWithType);
+ ZNRecord znRecord = ZKMetadataProvider.getZnRecord(_propertyStore, zkPath);
+ String creationTime =
SIMPLE_DATE_FORMAT.format(znRecord.getCreationTime());
Review comment:
It occurred to me that it may be better to return a `long` , in seconds
since epoch. Better granularity, less parsing and code on either side (read:
easier for automation and scripts)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
