codecov-io edited a comment on pull request #6316:
URL: https://github.com/apache/incubator-pinot/pull/6316#issuecomment-738569252
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6316?src=pr&el=h1)
Report
> Merging
[#6316](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io commented on pull request #6316:
URL: https://github.com/apache/incubator-pinot/pull/6316#issuecomment-738569252
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6316?src=pr&el=h1)
Report
> Merging
[#6316](https://codecov.io/gh/apache/incubator-pinot/pull/6316?s
jackjlli commented on a change in pull request #6291:
URL: https://github.com/apache/incubator-pinot/pull/6291#discussion_r535832670
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java
##
@@ -0,0 +1,131 @@
+/**
jackjlli commented on pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738557020
The travis build was stuck in "Job Received" state, which lasts for 4 hours.
While the travis build doesn't run anything, we can skip the travis build and
merge this PR
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 9a5cc4b Use StringUtils.replace to avoid regex for setting literal
expression (#6314)
add 41a7722 F
mayankshriv merged pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
JBAhire opened a new pull request #6316:
URL: https://github.com/apache/incubator-pinot/pull/6316
## Description
I noticed that we are running CI on every single change including changes in
README, docs and licence files which is not necessary at all.
GitHub actions supports p
codecov-io edited a comment on pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1)
Report
> Merging
[#6315](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1)
Report
> Merging
[#6315](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1)
Report
> Merging
[#6315](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io commented on pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1)
Report
> Merging
[#6315](https://codecov.io/gh/apache/incubator-pinot/pull/6315?s
jackjlli closed pull request #5826:
URL: https://github.com/apache/incubator-pinot/pull/5826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
amrishlal closed pull request #6305:
URL: https://github.com/apache/incubator-pinot/pull/6305
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mayankshriv commented on a change in pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#discussion_r535741328
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##
@@ -81,6 +81,7 @@ private st
siddharthteotia merged pull request #6314:
URL: https://github.com/apache/incubator-pinot/pull/6314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 3cf3154 [TE]frontend - Build the tree parser for composite anomalies
(#6290)
add 9a5cc4b Use Str
Jackie-Jiang commented on a change in pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315#discussion_r535733881
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##
@@ -81,6 +81,7 @@ private s
mayankshriv opened a new pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315
Currently, we cannot select multiple controller tests and run them in IDE
successfully.
We see that after the first test that extends `ControllerTest`, the setup
for next test
is uns
pabrahamusa edited a comment on issue #6309:
URL:
https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473
We can do NOT searches using lucene regex patterns , so following should work
`TEXT_MATCH(log,'/.*/ NOT quick AND NOT brown')`
`TEXT_MATCH(log,'/.*/ NOT f
pabrahamusa edited a comment on issue #6309:
URL:
https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pabrahamusa edited a comment on issue #6309:
URL:
https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473
We can do NOT searches using lucene regex patterns , so following should work
`
TEXT_MATCH(log,'/.*/` NOT quick AND NOT brown')
TEXT_MATCH(log,'/.*/ NO
pabrahamusa closed issue #6309:
URL: https://github.com/apache/incubator-pinot/issues/6309
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pabrahamusa commented on issue #6309:
URL:
https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473
We can do NOT searches using lucene regex patterns , so following should work
TEXT_MATCH(log,'/.*/ NOT quick AND NOT brown')
TEXT_MATCH(log,'/.*/ NOT fox')
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3cf3154 [TE]frontend - Build the tree p
jihaozh merged pull request #6290:
URL: https://github.com/apache/incubator-pinot/pull/6290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
fx19880617 merged pull request #6312:
URL: https://github.com/apache/incubator-pinot/pull/6312
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9ce5d78 Include exception message in
npawar merged pull request #6296:
URL: https://github.com/apache/incubator-pinot/pull/6296
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fx19880617 commented on issue #6277:
URL:
https://github.com/apache/incubator-pinot/issues/6277#issuecomment-738336236
> Also @kishoreg had said on Slack:
>
> > after 2gb, we typically run into JVM limits on offset length etc.
>
> So maybe adding a warning if the tar output si
codecov-io edited a comment on pull request #6314:
URL: https://github.com/apache/incubator-pinot/pull/6314#issuecomment-738301725
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6314?src=pr&el=h1)
Report
> Merging
[#6314](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io commented on pull request #6314:
URL: https://github.com/apache/incubator-pinot/pull/6314#issuecomment-738301725
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6314?src=pr&el=h1)
Report
> Merging
[#6314](https://codecov.io/gh/apache/incubator-pinot/pull/6314?s
tejasajmera commented on pull request #6290:
URL: https://github.com/apache/incubator-pinot/pull/6290#issuecomment-738293160
@zhangloo333 Can you please take a look again, your comments are addressed
now.
This is an automate
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e8ceb2e [TE] rest-api - harleyjj/rca -
jihaozh merged pull request #6265:
URL: https://github.com/apache/incubator-pinot/pull/6265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
siddharthteotia opened a new pull request #6314:
URL: https://github.com/apache/incubator-pinot/pull/6314
For very large queries (several 100s of lines, size of single query 50KB+),
@mayankshriv had noticed the overhead of SqlNode.toString when converting the
predicates to literal express
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 47a30ba [TE]frontend - Build new subrou
jihaozh merged pull request #6263:
URL: https://github.com/apache/incubator-pinot/pull/6263
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
kkrugler commented on issue #6311:
URL:
https://github.com/apache/incubator-pinot/issues/6311#issuecomment-738273485
@fx19880617 - yes, thanks. Added some comments on #6277, closing this one.
This is an automated message fro
kkrugler closed issue #6311:
URL: https://github.com/apache/incubator-pinot/issues/6311
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kkrugler commented on issue #6277:
URL:
https://github.com/apache/incubator-pinot/issues/6277#issuecomment-738273193
Also @kishoreg had said on Slack:
> after 2gb, we typically run into JVM limits on offset length etc.
So maybe adding a warning if the tar output size is > 2GB?
kkrugler commented on issue #6277:
URL:
https://github.com/apache/incubator-pinot/issues/6277#issuecomment-738272266
I think this is a `tar` format limitation, not `gzip`. As per
https://commons.apache.org/proper/commons-compress/tar.html, I think you want
to switch to using BIGNUMBER_POS
npawar opened a new issue #6313:
URL: https://github.com/apache/incubator-pinot/issues/6313
In production environments, the Cluster Manager cannot be exposed to all
users as-is, because it contains operations which can change the state of
Pinot. The goal is to add basic authentication and
kishoreg commented on issue #6308:
URL:
https://github.com/apache/incubator-pinot/issues/6308#issuecomment-738194604
Can do this instead
1. Add an API to get the status of consuming segment across all servers
(including offset is possible)
2. If the status is bad/error because of wha
npawar opened a new pull request #6312:
URL: https://github.com/apache/incubator-pinot/pull/6312
When validating an invalid table config, the reason is not returned in the
result in swagger. It is returned correctly in add table. Doing the same in
validate, so that the cluster manager can
npawar commented on pull request #6296:
URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-738172104
Thanks @shahsank3t ! I will fix the API for the validate.
This is an automated message from the Apache Gi
fx19880617 commented on issue #6311:
URL:
https://github.com/apache/incubator-pinot/issues/6311#issuecomment-738162768
I think this is duplicated with
https://github.com/apache/incubator-pinot/issues/6277
This is an automat
mcvsubbu commented on issue #6308:
URL:
https://github.com/apache/incubator-pinot/issues/6308#issuecomment-738148942
I disagree that ERROR state should trigger a consume stop. The ERROR state
is set (perhaps not best name) when the segment build fails. We can change the
name to SEGMENT_B
codecov-io edited a comment on pull request #6296:
URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-734230974
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6296?src=pr&el=h1)
Report
> Merging
[#6296](https://codecov.io/gh/apache/incubator-pinot/pull
mcvsubbu commented on a change in pull request #6286:
URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r535414983
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/TableDataManagerType.java
##
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the
shahsank3t commented on pull request #6296:
URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-738116481
@npawar Fixed issues you reported.
I didn't receive the complete error log in API response like you mentioned
but the below one:
> {"code":400,"error":"Invalid t
kkrugler opened a new issue #6311:
URL: https://github.com/apache/incubator-pinot/issues/6311
Currently a big segment fails during the “converting segment” phase:
```
Converting segment:
/tmp/pinot-d6bab609-8906-4c84-966b-5f96d41b1d80/output/crawldata_OFFLINE_2018-10-13_2020-10-11
pabrahamusa commented on issue #6309:
URL:
https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738075426
Also it would be good to support NOT searches
at the moment OR and AND will work i.e.
TEXT_MATCH(data,'quick AND brown AND fox') - works
TEXT_MATCH(data,'qui
tejasajmera opened a new pull request #6310:
URL: https://github.com/apache/incubator-pinot/pull/6310
This involves the front-end changes to use the Performance API for
displaying the Alert Performance Stats
This is an autom
53 matches
Mail list logo