[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6316: Avoids triggering GH action workflow on non-code changes

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #6316: URL: https://github.com/apache/incubator-pinot/pull/6316#issuecomment-738569252 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6316?src=pr&el=h1) Report > Merging [#6316](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io commented on pull request #6316: Avoids triggering GH action workflow on non-code changes

2020-12-03 Thread GitBox
codecov-io commented on pull request #6316: URL: https://github.com/apache/incubator-pinot/pull/6316#issuecomment-738569252 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6316?src=pr&el=h1) Report > Merging [#6316](https://codecov.io/gh/apache/incubator-pinot/pull/6316?s

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6291: Add consumption rate limiter for LLConsumer

2020-12-03 Thread GitBox
jackjlli commented on a change in pull request #6291: URL: https://github.com/apache/incubator-pinot/pull/6291#discussion_r535832670 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java ## @@ -0,0 +1,131 @@ +/**

[GitHub] [incubator-pinot] jackjlli commented on pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
jackjlli commented on pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738557020 The travis build was stuck in "Job Received" state, which lasts for 4 hours. While the travis build doesn't run anything, we can skip the travis build and merge this PR

[incubator-pinot] branch master updated (9a5cc4b -> 41a7722)

2020-12-03 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9a5cc4b Use StringUtils.replace to avoid regex for setting literal expression (#6314) add 41a7722 F

[GitHub] [incubator-pinot] mayankshriv merged pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
mayankshriv merged pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-pinot] JBAhire opened a new pull request #6316: Avoids triggering GH action workflow on non-code changes

2020-12-03 Thread GitBox
JBAhire opened a new pull request #6316: URL: https://github.com/apache/incubator-pinot/pull/6316 ## Description I noticed that we are running CI on every single change including changes in README, docs and licence files which is not necessary at all. GitHub actions supports p

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1) Report > Merging [#6315](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1) Report > Merging [#6315](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1) Report > Merging [#6315](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io commented on pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
codecov-io commented on pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#issuecomment-738480590 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6315?src=pr&el=h1) Report > Merging [#6315](https://codecov.io/gh/apache/incubator-pinot/pull/6315?s

[GitHub] [incubator-pinot] jackjlli closed pull request #5826: Identify if the values are converted from map and emit server metric

2020-12-03 Thread GitBox
jackjlli closed pull request #5826: URL: https://github.com/apache/incubator-pinot/pull/5826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] amrishlal closed pull request #6305: Run pinot-controller test cases within a TestNG suite.

2020-12-03 Thread GitBox
amrishlal closed pull request #6305: URL: https://github.com/apache/incubator-pinot/pull/6305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
mayankshriv commented on a change in pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#discussion_r535741328 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java ## @@ -81,6 +81,7 @@ private st

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6314: Use StringUtils.replace for setting string literal expression

2020-12-03 Thread GitBox
siddharthteotia merged pull request #6314: URL: https://github.com/apache/incubator-pinot/pull/6314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (3cf3154 -> 9a5cc4b)

2020-12-03 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3cf3154 [TE]frontend - Build the tree parser for composite anomalies (#6290) add 9a5cc4b Use Str

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
Jackie-Jiang commented on a change in pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315#discussion_r535733881 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java ## @@ -81,6 +81,7 @@ private s

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #6315: Fix: Close HelixAdmin appropriately, when setting up Helix Cluster.

2020-12-03 Thread GitBox
mayankshriv opened a new pull request #6315: URL: https://github.com/apache/incubator-pinot/pull/6315 Currently, we cannot select multiple controller tests and run them in IDE successfully. We see that after the first test that extends `ControllerTest`, the setup for next test is uns

[GitHub] [incubator-pinot] pabrahamusa edited a comment on issue #6309: TEXT index negative searches not working

2020-12-03 Thread GitBox
pabrahamusa edited a comment on issue #6309: URL: https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473 We can do NOT searches using lucene regex patterns , so following should work `TEXT_MATCH(log,'/.*/ NOT quick AND NOT brown')` `TEXT_MATCH(log,'/.*/ NOT f

[GitHub] [incubator-pinot] pabrahamusa edited a comment on issue #6309: TEXT index negative searches not working

2020-12-03 Thread GitBox
pabrahamusa edited a comment on issue #6309: URL: https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] pabrahamusa edited a comment on issue #6309: TEXT index negative searches not working

2020-12-03 Thread GitBox
pabrahamusa edited a comment on issue #6309: URL: https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473 We can do NOT searches using lucene regex patterns , so following should work ` TEXT_MATCH(log,'/.*/` NOT quick AND NOT brown') TEXT_MATCH(log,'/.*/ NO

[GitHub] [incubator-pinot] pabrahamusa closed issue #6309: TEXT index negative searches not working

2020-12-03 Thread GitBox
pabrahamusa closed issue #6309: URL: https://github.com/apache/incubator-pinot/issues/6309 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] pabrahamusa commented on issue #6309: TEXT index negative searches not working

2020-12-03 Thread GitBox
pabrahamusa commented on issue #6309: URL: https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738399473 We can do NOT searches using lucene regex patterns , so following should work TEXT_MATCH(log,'/.*/ NOT quick AND NOT brown') TEXT_MATCH(log,'/.*/ NOT fox')

[incubator-pinot] branch master updated: [TE]frontend - Build the tree parser for composite anomalies (#6290)

2020-12-03 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3cf3154 [TE]frontend - Build the tree p

[GitHub] [incubator-pinot] jihaozh merged pull request #6290: [TE]frontend - Build the tree parser for composite anomalies

2020-12-03 Thread GitBox
jihaozh merged pull request #6290: URL: https://github.com/apache/incubator-pinot/pull/6290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] fx19880617 merged pull request #6312: Include exception message in the ControllerApplicationException for /validate

2020-12-03 Thread GitBox
fx19880617 merged pull request #6312: URL: https://github.com/apache/incubator-pinot/pull/6312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-pinot] branch master updated: Include exception message in the ControllerApplicationException for /validate (#6312)

2020-12-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 9ce5d78 Include exception message in

[GitHub] [incubator-pinot] npawar merged pull request #6296: support to add offline and realtime tables, individually able to add schema and schema listing in UI

2020-12-03 Thread GitBox
npawar merged pull request #6296: URL: https://github.com/apache/incubator-pinot/pull/6296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] fx19880617 commented on issue #6277: Creating segment larger than 8GB will fail due to gzip limitation

2020-12-03 Thread GitBox
fx19880617 commented on issue #6277: URL: https://github.com/apache/incubator-pinot/issues/6277#issuecomment-738336236 > Also @kishoreg had said on Slack: > > > after 2gb, we typically run into JVM limits on offset length etc. > > So maybe adding a warning if the tar output si

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6314: Use StringUtils.replace for setting string literal expression

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #6314: URL: https://github.com/apache/incubator-pinot/pull/6314#issuecomment-738301725 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6314?src=pr&el=h1) Report > Merging [#6314](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io commented on pull request #6314: Use StringUtils.replace for setting string literal expression

2020-12-03 Thread GitBox
codecov-io commented on pull request #6314: URL: https://github.com/apache/incubator-pinot/pull/6314#issuecomment-738301725 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6314?src=pr&el=h1) Report > Merging [#6314](https://codecov.io/gh/apache/incubator-pinot/pull/6314?s

[GitHub] [incubator-pinot] tejasajmera commented on pull request #6290: [TE]frontend - Build the tree parser for composite anomalies

2020-12-03 Thread GitBox
tejasajmera commented on pull request #6290: URL: https://github.com/apache/incubator-pinot/pull/6290#issuecomment-738293160 @zhangloo333 Can you please take a look again, your comments are addressed now. This is an automate

[incubator-pinot] branch master updated: [TE] rest-api - harleyjj/rca - add forecast as baseline option for metric/timeseries endpoint (#6265)

2020-12-03 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e8ceb2e [TE] rest-api - harleyjj/rca -

[GitHub] [incubator-pinot] jihaozh merged pull request #6265: [TE] rest-api - harleyjj/rca - add forecast as baseline option for me…

2020-12-03 Thread GitBox
jihaozh merged pull request #6265: URL: https://github.com/apache/incubator-pinot/pull/6265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #6314: Use StringUtils.replace for setting string literal expression

2020-12-03 Thread GitBox
siddharthteotia opened a new pull request #6314: URL: https://github.com/apache/incubator-pinot/pull/6314 For very large queries (several 100s of lines, size of single query 50KB+), @mayankshriv had noticed the overhead of SqlNode.toString when converting the predicates to literal express

[incubator-pinot] branch master updated: [TE]frontend - Build new subroutes for single-metric-anomalies and composite-anomalies (#6263)

2020-12-03 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 47a30ba [TE]frontend - Build new subrou

[GitHub] [incubator-pinot] jihaozh merged pull request #6263: [TE]frontend - Build new subroutes for single-metric-anomalies and composite-anomalies

2020-12-03 Thread GitBox
jihaozh merged pull request #6263: URL: https://github.com/apache/incubator-pinot/pull/6263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] kkrugler commented on issue #6311: Support tarred segments > 8GB

2020-12-03 Thread GitBox
kkrugler commented on issue #6311: URL: https://github.com/apache/incubator-pinot/issues/6311#issuecomment-738273485 @fx19880617 - yes, thanks. Added some comments on #6277, closing this one. This is an automated message fro

[GitHub] [incubator-pinot] kkrugler closed issue #6311: Support tarred segments > 8GB

2020-12-03 Thread GitBox
kkrugler closed issue #6311: URL: https://github.com/apache/incubator-pinot/issues/6311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-pinot] kkrugler commented on issue #6277: Creating segment larger than 8GB will fail due to gzip limitation

2020-12-03 Thread GitBox
kkrugler commented on issue #6277: URL: https://github.com/apache/incubator-pinot/issues/6277#issuecomment-738273193 Also @kishoreg had said on Slack: > after 2gb, we typically run into JVM limits on offset length etc. So maybe adding a warning if the tar output size is > 2GB?

[GitHub] [incubator-pinot] kkrugler commented on issue #6277: Creating segment larger than 8GB will fail due to gzip limitation

2020-12-03 Thread GitBox
kkrugler commented on issue #6277: URL: https://github.com/apache/incubator-pinot/issues/6277#issuecomment-738272266 I think this is a `tar` format limitation, not `gzip`. As per https://commons.apache.org/proper/commons-compress/tar.html, I think you want to switch to using BIGNUMBER_POS

[GitHub] [incubator-pinot] npawar opened a new issue #6313: Authentication to Cluster Manager

2020-12-03 Thread GitBox
npawar opened a new issue #6313: URL: https://github.com/apache/incubator-pinot/issues/6313 In production environments, the Cluster Manager cannot be exposed to all users as-is, because it contains operations which can change the state of Pinot. The goal is to add basic authentication and

[GitHub] [incubator-pinot] kishoreg commented on issue #6308: Errors in consuming segment completely stops consumption

2020-12-03 Thread GitBox
kishoreg commented on issue #6308: URL: https://github.com/apache/incubator-pinot/issues/6308#issuecomment-738194604 Can do this instead 1. Add an API to get the status of consuming segment across all servers (including offset is possible) 2. If the status is bad/error because of wha

[GitHub] [incubator-pinot] npawar opened a new pull request #6312: Include exception message in the ControllerApplicationException for /validate

2020-12-03 Thread GitBox
npawar opened a new pull request #6312: URL: https://github.com/apache/incubator-pinot/pull/6312 When validating an invalid table config, the reason is not returned in the result in swagger. It is returned correctly in add table. Doing the same in validate, so that the cluster manager can

[GitHub] [incubator-pinot] npawar commented on pull request #6296: support to add offline and realtime tables, individually able to add schema and schema listing in UI

2020-12-03 Thread GitBox
npawar commented on pull request #6296: URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-738172104 Thanks @shahsank3t ! I will fix the API for the validate. This is an automated message from the Apache Gi

[GitHub] [incubator-pinot] fx19880617 commented on issue #6311: Support tarred segments > 8GB

2020-12-03 Thread GitBox
fx19880617 commented on issue #6311: URL: https://github.com/apache/incubator-pinot/issues/6311#issuecomment-738162768 I think this is duplicated with https://github.com/apache/incubator-pinot/issues/6277 This is an automat

[GitHub] [incubator-pinot] mcvsubbu commented on issue #6308: Errors in consuming segment completely stops consumption

2020-12-03 Thread GitBox
mcvsubbu commented on issue #6308: URL: https://github.com/apache/incubator-pinot/issues/6308#issuecomment-738148942 I disagree that ERROR state should trigger a consume stop. The ERROR state is set (perhaps not best name) when the segment build fails. We can change the name to SEGMENT_B

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6296: support to add offline and realtime tables, individually able to add schema and schema listing in UI

2020-12-03 Thread GitBox
codecov-io edited a comment on pull request #6296: URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-734230974 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6296?src=pr&el=h1) Report > Merging [#6296](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6286: Adding offline dimension table creation and segment assignment

2020-12-03 Thread GitBox
mcvsubbu commented on a change in pull request #6286: URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r535414983 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/TableDataManagerType.java ## @@ -0,0 +1,23 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] shahsank3t commented on pull request #6296: support to add offline and realtime tables, individually able to add schema and schema listing in UI

2020-12-03 Thread GitBox
shahsank3t commented on pull request #6296: URL: https://github.com/apache/incubator-pinot/pull/6296#issuecomment-738116481 @npawar Fixed issues you reported. I didn't receive the complete error log in API response like you mentioned but the below one: > {"code":400,"error":"Invalid t

[GitHub] [incubator-pinot] kkrugler opened a new issue #6311: Support tarred segments > 8GB

2020-12-03 Thread GitBox
kkrugler opened a new issue #6311: URL: https://github.com/apache/incubator-pinot/issues/6311 Currently a big segment fails during the “converting segment” phase: ``` Converting segment: /tmp/pinot-d6bab609-8906-4c84-966b-5f96d41b1d80/output/crawldata_OFFLINE_2018-10-13_2020-10-11

[GitHub] [incubator-pinot] pabrahamusa commented on issue #6309: TEXT index negative searches not working

2020-12-03 Thread GitBox
pabrahamusa commented on issue #6309: URL: https://github.com/apache/incubator-pinot/issues/6309#issuecomment-738075426 Also it would be good to support NOT searches at the moment OR and AND will work i.e. TEXT_MATCH(data,'quick AND brown AND fox') - works TEXT_MATCH(data,'qui

[GitHub] [incubator-pinot] tejasajmera opened a new pull request #6310: [TE]frontend - Refactor to integrate the Performance Stats API into the front-end

2020-12-03 Thread GitBox
tejasajmera opened a new pull request #6310: URL: https://github.com/apache/incubator-pinot/pull/6310 This involves the front-end changes to use the Performance API for displaying the Alert Performance Stats This is an autom