mayankshriv opened a new pull request #6315:
URL: https://github.com/apache/incubator-pinot/pull/6315
Currently, we cannot select multiple controller tests and run them in IDE
successfully.
We see that after the first test that extends `ControllerTest`, the setup
for next test
is unsuccessful due to the following reason:
- In `startController`, we setup Helix as well as Pinot Controllers.
- Both of these end up opening a ZKClient, however, only one of them (Pinot
Controller)
closes the zkClient.
- Since Helix controller does not close the ZKCLient, it remains alive, even
after the
first test's `cleanup()` is called.
- Given that we use SharedZKClientFactory which is a singleton class, and
when running
multiple tests from IDE, they use the same JVM, the second test ends up
getting
an obsolete ZKClient from preivous test, which is already disconnected.
This PR fixes the issue by appropriately closing the HelixAdmin (which
closes the ZKClient)
when completed.
## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document,
etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the
documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
