haibow merged pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
haibow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5548e79 Table indexing config validati
icefury71 commented on a change in pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#discussion_r490664421
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -225,4 +233,99 @@ private static void validateTie
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d9aec17 Improve the realtime time creat
snleee merged pull request #6032:
URL: https://github.com/apache/incubator-pinot/pull/6032
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
snleee commented on a change in pull request #6032:
URL: https://github.com/apache/incubator-pinot/pull/6032#discussion_r490648403
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -504,6 +504
mcvsubbu commented on a change in pull request #6032:
URL: https://github.com/apache/incubator-pinot/pull/6032#discussion_r490645088
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -504,6 +5
snleee commented on pull request #6032:
URL: https://github.com/apache/incubator-pinot/pull/6032#issuecomment-694560867
@Jackie-Jiang I will rename the description and title.
This is an automated message from the Apache Git
Jackie-Jiang commented on pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#issuecomment-694558309
@fx19880617 @siddharthteotia The current code (without this PR) is the
approach of using separate implementation for streaming query, and turns out
the code is almo
icefury71 commented on pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#issuecomment-694557062
> As discussed offline, it would be nice to have some validations on index
columns which cannot be in noDictionary columns (e.g. if column has inverted
index, it shoul
snleee opened a new pull request #6032:
URL: https://github.com/apache/incubator-pinot/pull/6032
1. Added the precondition check for time interval from segment metadata
2. Added unit tests
This is an automated message from
npawar commented on pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#issuecomment-694554063
As discussed offline, it would be nice to have some validations on index
columns which cannot be in noDictionary columns (e.g. if column has inverted
index, it should not
snleee commented on pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694553611
Closing the pull request since the current code correctly validates the time
column that I would like to do.
npawar commented on a change in pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#discussion_r490616268
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -225,4 +233,99 @@ private static void validateTierCo
snleee closed pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch remove_consuming_partition_info
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 200bef6ecd05c177b829b0b6ab1995916c13a7c6
Author: Xiaotian (Jackie) Jiang
AuthorDate: T
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch remove_consuming_partition_info
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 200bef6 Remove the partition info from the consuming segment ZK
metadata
This br
Jackie-Jiang commented on issue #6029:
URL:
https://github.com/apache/incubator-pinot/issues/6029#issuecomment-694552426
Perf testing branch which removes the partition info for consuming segments:
https://github.com/apache/incubator-pinot/tree/remove_consuming_partition_info
---
Jackie-Jiang commented on issue #6029:
URL:
https://github.com/apache/incubator-pinot/issues/6029#issuecomment-694552301
Fix for the issue: #6031
This is an automated message from the Apache Git Service.
To respond to the m
npawar commented on a change in pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#discussion_r490611880
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -100,9 +101,13 @@ private static void validateValida
npawar commented on a change in pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#discussion_r490611452
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##
@@ -504,6 +504
siddharthteotia commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490610341
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##
@@ -94,7 +96,8 @@ public sy
siddharthteotia commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490610341
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##
@@ -94,7 +96,8 @@ public sy
siddharthteotia commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490610341
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##
@@ -94,7 +96,8 @@ public sy
siddharthteotia commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490610006
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/QueryExecutor.java
##
@@ -54,6 +55,16 @@ void init(PinotConfi
Jackie-Jiang opened a new pull request #6031:
URL: https://github.com/apache/incubator-pinot/pull/6031
## Description
Fix for #6029
In consuming segment, update the partition info when ingesting new records.
Log a warning and emit a metric **REALTIME_PARTITION_MISMATCH** when the
snleee commented on pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694543559
@jackjlli @kishoreg Thank you for the pointer. Actually, #5966 adds the
validation and already fixed this issue. I slightly improved the validation and
keep the test tha
snleee edited a comment on pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694543559
@jackjlli @kishoreg Thank you for the pointer. Actually, #5966 recently
adds the validation and already fixed this issue. I slightly improved the
validation and k
fx19880617 commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490604509
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/QueryExecutor.java
##
@@ -54,6 +55,16 @@ void init(PinotConfigurat
kishoreg commented on a change in pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#discussion_r490603362
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##
@@ -1226,6 +1231,27 @@ voi
snleee commented on pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694539036
```
2020/09/17 20:36:52.666 ERROR
[SegmentCompletionFSM_X__3__0__20200915T2142Z] [grizzly-http-server-3]
[pinot-controller] [] Caught exception while committing se
snleee opened a new pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030
Currently, there is no validation on the time column name from
the table config when creating a realtime table. Invalid time
configuration would cause the failure in commit stage because
jihaozh merged pull request #6025:
URL: https://github.com/apache/incubator-pinot/pull/6025
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 348da46 [TE] UI - add severity level in
mayankshriv opened a new issue #6029:
URL: https://github.com/apache/incubator-pinot/issues/6029
The current code simply assumes partitionId from kafka partition to be in
accordance with the partition function defined in table config. In case there
is a mis-match on kafka partition and wha
icefury71 commented on a change in pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#discussion_r490584635
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -65,6 +68,7 @@ public static void validate(TableC
icefury71 commented on a change in pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#discussion_r490584598
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -225,4 +229,54 @@ private static void validateTie
icefury71 commented on a change in pull request #6017:
URL: https://github.com/apache/incubator-pinot/pull/6017#discussion_r490584598
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -225,4 +229,54 @@ private static void validateTie
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e72a856 [Clean up] Separate TextIndex from InvertedIndex (#6010)
add cef2740 List of partitioners
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e72a856 [Clean up] Separate TextIndex from InvertedIndex (#6010)
add cef2740 List of partitioners
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e72a856 [Clean up] Separate TextIndex from InvertedIndex (#6010)
add cef2740 List of partitioners
npawar merged pull request #6021:
URL: https://github.com/apache/incubator-pinot/pull/6021
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Jackie-Jiang merged pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 2da8fd4 add `@types/react-router` dep (#6023)
add e72a856 [Clean up] Separate TextIndex from Inverted
Jackie-Jiang commented on a change in pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010#discussion_r490525042
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/ColumnIndexContainer.java
##
@@ -42,14 +43,14 @@
Invert
siddharthteotia commented on a change in pull request #6010:
URL: https://github.com/apache/incubator-pinot/pull/6010#discussion_r490504285
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/column/ColumnIndexContainer.java
##
@@ -42,14 +43,14 @@
Inv
mr-agrwal closed issue #5982:
URL: https://github.com/apache/incubator-pinot/issues/5982
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
kishoreg commented on issue #6028:
URL:
https://github.com/apache/incubator-pinot/issues/6028#issuecomment-694310325
```
private void setGroupByResults(BrokerResponseNative brokerResponseNative,
Collection dataTables) {
// Merge results from all data tables.
String[]
mr-agrwal opened a new issue #6028:
URL: https://github.com/apache/incubator-pinot/issues/6028
Right now for some heavy Distinct Count Group By queries, we see a
bottleneck in Broker performance.
This can be improved by converting the Broker Aggregation Phase from
single-threaded to mul
49 matches
Mail list logo
