npawar commented on a change in pull request #6030:
URL: https://github.com/apache/incubator-pinot/pull/6030#discussion_r490611880
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -100,9 +101,13 @@ private static void validateValidationConfig(TableConfig
tableConfig, @Nullable
}
// timeColumnName can be null in OFFLINE table
if (timeColumnName != null && schema != null) {
- Preconditions.checkState(schema.getSpecForTimeColumn(timeColumnName) !=
null,
+ FieldSpec timeColumnFieldSpec =
schema.getSpecForTimeColumn(timeColumnName);
Review comment:
There's a TableConfigUtilsTest which exhaustively tests validations done
here. Can you add one for timeColumn being TIME/DATE_TIME only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
