bradengroom commented on issue #5951:
URL:
https://github.com/apache/incubator-pinot/issues/5951#issuecomment-689303483
You can assign this to me if you'd like. I've got an initial implementation
working locally. I just need to do some polish and add tests.
--
codecov-commenter edited a comment on pull request #5718:
URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-685294191
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5718?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(
jackjlli commented on a change in pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#discussion_r485313915
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##
@@ -586,22 +586,32 @@ public boolean isSingleValue(
jackjlli commented on pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#issuecomment-689274482
Most of the cases can be covered by validating pinot schema and avro schema.
One tricky thing is that when all the fields are required to be fetched, we
convert the avr
jackjlli commented on a change in pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#discussion_r485312383
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##
@@ -586,22 +586,32 @@ public boolean isSingleValue(
mayankshriv commented on a change in pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#discussion_r485309751
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##
@@ -586,22 +586,32 @@ public boolean isSingleVal
mayankshriv commented on pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#issuecomment-689270729
@jackjlli Could you describe the case which is not caught by schema level
check?
This is an automat
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch hotfix-minmax
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/hotfix-minmax by this push:
new 2c2e826 Add missing null c
mr-agrwal closed pull request #5989:
URL: https://github.com/apache/incubator-pinot/pull/5989
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch hotfix-minmax
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/hotfix-minmax by this push:
new 801af45 Lazy initializatio
Jackie-Jiang commented on pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#issuecomment-689256109
High level question, do we really need row level validation? What is the
overhead of this validation?
Seems like the validation only applies to the Avro reader. I
codecov-commenter edited a comment on pull request #5718:
URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-685294191
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5718?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(
Jackie-Jiang commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r485258306
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/Collector.java
##
@@ -0,0 +1,55 @@
+/**
+ * Licens
Jackie-Jiang closed pull request #5952:
URL: https://github.com/apache/incubator-pinot/pull/5952
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Jackie-Jiang commented on pull request #5952:
URL: https://github.com/apache/incubator-pinot/pull/5952#issuecomment-689238164
Replaced with #5973
This is an automated message from the Apache Git Service.
To respond to the me
Jackie-Jiang merged pull request #5973:
URL: https://github.com/apache/incubator-pinot/pull/5973
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d062cfd Add InIdSetTransformFunction (
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f88a275 Add streaming query handler (#
Jackie-Jiang merged pull request #5717:
URL: https://github.com/apache/incubator-pinot/pull/5717
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch severity-alerter
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard c95c341 address comments
discard 5511721 refactor
discard f614acb severity alerter & unit test
jihaozh merged pull request #5972:
URL: https://github.com/apache/incubator-pinot/pull/5972
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aa6d48f [TE] add threshold-based anomal
Jackie-Jiang commented on a change in pull request #5717:
URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r485254555
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##
@@ -190,7 +190,12 @@
public static final
akshayrai commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-pinot/pull/5962#discussion_r485229689
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/AnomalySubscriptionGroupNotificationManager.java
##
Jackie-Jiang commented on a change in pull request #5717:
URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r485227398
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/grpc/GrpcRequestBuilder.java
##
@@ -0,0 +1,106 @@
+/**
+ * Licensed t
shahsank3t commented on pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981#issuecomment-689161988
@kishoreg Addressed your feedback and also added Success & Error
Notification Alerts on completion of Update/Delete Operation.
--
Jackie-Jiang merged pull request #5986:
URL: https://github.com/apache/incubator-pinot/pull/5986
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2d60312 Improve code coverage for pino
Jackie-Jiang commented on a change in pull request #5986:
URL: https://github.com/apache/incubator-pinot/pull/5986#discussion_r485215521
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java
##
@@ -75,15 +75,6 @@ public String g
Jackie-Jiang commented on issue #5893:
URL:
https://github.com/apache/incubator-pinot/issues/5893#issuecomment-689154234
@mr-agrwal In order to aggregate the values, we have to store the serialized
`Set` into the star-tree (same as what we need to store for `DistinctCount`.
The size of th
Jackie-Jiang commented on pull request #5989:
URL: https://github.com/apache/incubator-pinot/pull/5989#issuecomment-689147826
We should not use a separate fixed timeout for planning phase, but use the
query timeout instead: #5990
--
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new cd35332 Use query timeout for planning
Jackie-Jiang merged pull request #5990:
URL: https://github.com/apache/incubator-pinot/pull/5990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Jackie-Jiang opened a new pull request #5990:
URL: https://github.com/apache/incubator-pinot/pull/5990
## Description
Currently the `CombinePlanNode` is using fixed 10 seconds as the timeout for
the multi-threaded query planning, and the query planning time is not counted
into the timeo
jihaozh commented on a change in pull request #5972:
URL: https://github.com/apache/incubator-pinot/pull/5972#discussion_r485119192
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/components/ThresholdSeverityLabeler.java
##
@@ -0,0 +1,88
jihaozh commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-pinot/pull/5962#discussion_r485111503
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java
##
@@ -570,4 +574,19 @@ public Res
jihaozh commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-pinot/pull/5962#discussion_r485111715
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
##
@@ -167,6 +175,14 @@
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch severity-alerter
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 5511721 refactor
add c95c341 address comments
No new revisions were added by this update.
mr-agrwal opened a new pull request #5989:
URL: https://github.com/apache/incubator-pinot/pull/5989
## Description
Increasing the default timeout as we are seeing the following exceptions.
Exception processing requestId 786
java.lang.RuntimeException: Caught exception while running
fx19880617 commented on a change in pull request #5717:
URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r485021999
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/transport/grpc/GrpcRequestBuilder.java
##
@@ -0,0 +1,106 @@
+/**
+ * Licensed to
fx19880617 commented on pull request #5987:
URL: https://github.com/apache/incubator-pinot/pull/5987#issuecomment-688946724
Can we parameterize `JAVA_VERSION` and default still to 8?
So out build script can set `JAVA_VERSION` to 11 if needed.
kishoreg commented on pull request #5981:
URL: https://github.com/apache/incubator-pinot/pull/5981#issuecomment-688936628
Tested it and it works fine. Few things
- Ask for confirmation before saving instead of before editing
- Refresh seems to refresh the entire tree, just refresh the
KKcorps commented on a change in pull request #5988:
URL: https://github.com/apache/incubator-pinot/pull/5988#discussion_r484713514
##
File path:
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java
##
@@ -77,13 +76,31
kishoreg commented on a change in pull request #5988:
URL: https://github.com/apache/incubator-pinot/pull/5988#discussion_r484699665
##
File path:
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotDriver.java
##
@@ -37,16 +38,18 @@
public class PinotD
KKcorps opened a new pull request #5988:
URL: https://github.com/apache/incubator-pinot/pull/5988
Currently, there is no mechanism in JDBC connector to use the correct broker
to execute a query.
The PR fixes the issue by getting Tenant as property in the JDBC connector
and fetching brok
45 matches
Mail list logo
