Jackie-Jiang commented on a change in pull request #5717:
URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r485254555



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -190,7 +190,12 @@
     public static final String CONFIG_OF_QUERY_EXECUTOR_CLASS = 
"pinot.server.query.executor.class";
     public static final String CONFIG_OF_REQUEST_HANDLER_FACTORY_CLASS = 
"pinot.server.requestHandlerFactory.class";
     public static final String CONFIG_OF_NETTY_PORT = 
"pinot.server.netty.port";
+    public static final String CONFIG_OF_ENABLE_GRPC_SERVER = 
"pinot.server.grpc.enable";
+    public static final boolean DEFAULT_ENABLE_GRPC_SERVER = false;
+    public static final String CONFIG_OF_GRPC_PORT = "pinot.server.grpc.port";

Review comment:
       Added the port info into the Helix `InstanceConfig` under `grpcPort`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to