[GitHub] [incubator-pinot] fx19880617 merged pull request #5844: Move quickstart tests to use Java 14 release

2020-08-10 Thread GitBox
fx19880617 merged pull request #5844: URL: https://github.com/apache/incubator-pinot/pull/5844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-pinot] branch master updated (3785aa7 -> c04b8b3)

2020-08-10 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3785aa7 Improving retention manager to handle segment lineage clean-up (#5828) add c04b8b3 Move qui

[GitHub] [incubator-pinot] adriancole opened a new pull request #5844: Move quickstart tests to use Java 14 release

2020-08-10 Thread GitBox
adriancole opened a new pull request #5844: URL: https://github.com/apache/incubator-pinot/pull/5844 Java 14 is patch 2 at this point, but we were using early access still. ## Description Add a description of your PR here. A good description should include pointers to an issue o

[GitHub] [incubator-pinot] yupeng9 commented on issue #5843: Public API checker before release

2020-08-10 Thread GitBox
yupeng9 commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-671677633 A checker will help detect the breaks, either we want to disallow it or document it in the release notes will depend on the policy we set up on 0.x releases. So it will be u

[GitHub] [incubator-pinot] yupeng9 edited a comment on issue #5843: Public API checker before release

2020-08-10 Thread GitBox
yupeng9 edited a comment on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-671677633 A checker will help detect the breaks, either we want to disallow it or document it in the release notes will depend on the policy we set up on 0.x releases. So it wi

[incubator-pinot] branch master updated (57d4b71 -> 3785aa7)

2020-08-10 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 57d4b71 [TE] Presto JDBC lib upgrade (#5841) add 3785aa7 Improving retention manager to handle segment

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5787: [Feature] - Spark Pinot Connector

2020-08-10 Thread GitBox
fx19880617 commented on a change in pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#discussion_r468275673 ## File path: pinot-connectors/pinot-spark-connector/src/main/scala/org/apache/pinot/connector/spark/datasource/PinotDataSourceReader.scala ##

[GitHub] [incubator-pinot] snleee merged pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee merged pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] fx19880617 commented on issue #5837: Apache Pulsar integration

2020-08-10 Thread GitBox
fx19880617 commented on issue #5837: URL: https://github.com/apache/incubator-pinot/issues/5837#issuecomment-671670690 Please take it @SandishKumarHN . Thanks! This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5843: Public API checker before release

2020-08-10 Thread GitBox
Jackie-Jiang commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-671664434 Does adding a checker mean not allowing changing of public API? For certain features, we might have to change the interface (e.g. the diff is to support transform and

[GitHub] [incubator-pinot] yupeng9 opened a new issue #5843: Public API checker before release

2020-08-10 Thread GitBox
yupeng9 opened a new issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843 It will be good to have a checker to scan the breaks on the APIs marked as `Public` and `Stable` as part of the release process. For example, this [diff](https://github.com/apache/incubator-

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5842: [TE] clean up legacy code

2020-08-10 Thread GitBox
akshayrai opened a new pull request #5842: URL: https://github.com/apache/incubator-pinot/pull/5842 * Removed the unused ContributorDataForDataReport related lines of code. * Removed logging of payload while creating/editing yaml configs.

[GitHub] [incubator-pinot] jihaozh merged pull request #5841: [TE] Presto JDBC lib upgrade

2020-08-10 Thread GitBox
jihaozh merged pull request #5841: URL: https://github.com/apache/incubator-pinot/pull/5841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-pinot] branch master updated (9f23e18 -> 57d4b71)

2020-08-10 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9f23e18 Tiered storage (#5793) add 57d4b71 [TE] Presto JDBC lib upgrade (#5841) No new revisions were

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5841: [TE] Presto JDBC lib upgrade

2020-08-10 Thread GitBox
vincentchenjl opened a new pull request #5841: URL: https://github.com/apache/incubator-pinot/pull/5841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-pinot] npawar merged pull request #5793: Tiered storage

2020-08-10 Thread GitBox
npawar merged pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch master updated (de14078 -> 9f23e18)

2020-08-10 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from de14078 Support post-aggregation in QueryContext (#5827) add 9f23e18 Tiered storage (#5793) No ne

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5827: Support post-aggregation in QueryContext

2020-08-10 Thread GitBox
Jackie-Jiang merged pull request #5827: URL: https://github.com/apache/incubator-pinot/pull/5827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-pinot] branch master updated (63a4fd4 -> de14078)

2020-08-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 63a4fd4 Clarifications in realtime provisioning helper (#5838) add de14078 Support post-aggregation i

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
Jackie-Jiang commented on pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#issuecomment-671609047 (Optional) Allow theta-sketch with only 2 arguments: theta-sketch column, parameters. It simply union the sketches without any extra predicate. Currently in order t

[incubator-pinot] branch master updated (debadaa -> 63a4fd4)

2020-08-10 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from debadaa [TE] enchance anomaly api to propagate feedback (#5823) add 63a4fd4 Clarifications in realt

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5838: Clarifications in realtime provisioning helper

2020-08-10 Thread GitBox
mcvsubbu merged pull request #5838: URL: https://github.com/apache/incubator-pinot/pull/5838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468201232 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ##

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r468200651 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,87 @@ privat

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r468200530 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,63 @@ privat

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r468200339 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,63 @@ privat

[GitHub] [incubator-pinot] jihaozh merged pull request #5823: [TE] enchance anomaly api to propagate feedback

2020-08-10 Thread GitBox
jihaozh merged pull request #5823: URL: https://github.com/apache/incubator-pinot/pull/5823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-pinot] branch master updated (7f8e65c -> debadaa)

2020-08-10 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 7f8e65c [TE] Fix template rendering errors (#5839) add debadaa [TE] enchance anomaly api to propagate

[incubator-pinot] branch migrate-publication-to-github-action updated (154eba9 -> 84674d0)

2020-08-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch migrate-publication-to-github-action in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 154eba9 Migrate publication from Travis CI to Github action add 84674d0 M

[incubator-pinot] branch master updated (cc7a344 -> 7f8e65c)

2020-08-10 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from cc7a344 [TE] UI changes for anomalies page v3(#5824) add 7f8e65c [TE] Fix template rendering err

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5840: [WIP] Migrate publication from Travis CI to Github action

2020-08-10 Thread GitBox
jackjlli opened a new pull request #5840: URL: https://github.com/apache/incubator-pinot/pull/5840 ## Description This PR: * migrates code publication from Travis CI to Github action. * hardcode version number so that submodule can be built independently. TODO: Add credential

[GitHub] [incubator-pinot] akshayrai merged pull request #5839: [TE] Fix template rendering errors

2020-08-10 Thread GitBox
akshayrai merged pull request #5839: URL: https://github.com/apache/incubator-pinot/pull/5839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch migrate-publication-to-github-action created (now 154eba9)

2020-08-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch migrate-publication-to-github-action in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 154eba9 Migrate publication from Travis CI to Github action This branch includ

[incubator-pinot] 01/01: Migrate publication from Travis CI to Github action

2020-08-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch migrate-publication-to-github-action in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 154eba9bdee652cb0a232c6d0725ba7f4f18745a Author: Jack Li(Analytics Engineering) Aut

[GitHub] [incubator-pinot] bkuang88 commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
bkuang88 commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468183845 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ## @@ -

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
codecov-commenter edited a comment on pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#issuecomment-671586172 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5832?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5839: [TE] Fix template rendering errors

2020-08-10 Thread GitBox
akshayrai opened a new pull request #5839: URL: https://github.com/apache/incubator-pinot/pull/5839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
codecov-commenter commented on pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#issuecomment-671586172 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5832?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #5838: Clarifications in realtime provisioning helper

2020-08-10 Thread GitBox
mcvsubbu opened a new pull request #5838: URL: https://github.com/apache/incubator-pinot/pull/5838 Updated the output based on recent feedback from Pinot SREs at LinkedIn ## Description Add a description of your PR here. A good description should include pointers to an issue or

[incubator-pinot] branch master updated (ce32362 -> cc7a344)

2020-08-10 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ce32362 Addressed issues in code review: (#5774) add cc7a344 [TE] UI changes for anomalies page v3(#58

[GitHub] [incubator-pinot] jihaozh merged pull request #5824: [TE] UI - Anomalies page v3

2020-08-10 Thread GitBox
jihaozh merged pull request #5824: URL: https://github.com/apache/incubator-pinot/pull/5824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] SandishKumarHN commented on issue #5837: Apache Pulsar integration

2020-08-10 Thread GitBox
SandishKumarHN commented on issue #5837: URL: https://github.com/apache/incubator-pinot/issues/5837#issuecomment-671576874 I would like to work on this if no one is already started working on it. This is an automated messag

[GitHub] [incubator-pinot] SandishKumarHN opened a new issue #5837: Apache Pulsar integration

2020-08-10 Thread GitBox
SandishKumarHN opened a new issue #5837: URL: https://github.com/apache/incubator-pinot/issues/5837 Add connector for ingesting from Apache Pulsar This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-10 Thread GitBox
fx19880617 commented on a change in pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836#discussion_r468148451 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java ## @@ -28,12 +28,16

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-10 Thread GitBox
fx19880617 commented on a change in pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836#discussion_r468068735 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java ## @@ -391,7 +393,11 @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
mayankshriv commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468141336 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ## @

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5588: Documentation/tool improvements

2020-08-10 Thread GitBox
mcvsubbu commented on issue #5588: URL: https://github.com/apache/incubator-pinot/issues/5588#issuecomment-671551128 More comments after using recent version: 1. Change the documentation so it does not say `RealtimeProvisioningHelperCommand` 2. Add a link to doc in the help message

[GitHub] [incubator-pinot] bkuang88 commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
bkuang88 commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468138173 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ## @@ -

[GitHub] [incubator-pinot] bkuang88 commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
bkuang88 commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468136912 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ## @@ -

[GitHub] [incubator-pinot] bkuang88 commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
bkuang88 commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468136800 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ## @@ -

[GitHub] [incubator-pinot] bkuang88 commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
bkuang88 commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r468125503 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java ## @@ -

[incubator-pinot] branch master updated (8a3cecb -> ce32362)

2020-08-10 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 8a3cecb [TE] frontend - harleyjj/forecast - show tool tip for fit and forecast (#5812) add ce3236

[GitHub] [incubator-pinot] siddharthteotia merged pull request #5774: Config recommendation engine

2020-08-10 Thread GitBox
siddharthteotia merged pull request #5774: URL: https://github.com/apache/incubator-pinot/pull/5774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] jihaozh merged pull request #5812: [TE] frontend - harleyjj/forecast - show tool tip for fit and forecast

2020-08-10 Thread GitBox
jihaozh merged pull request #5812: URL: https://github.com/apache/incubator-pinot/pull/5812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-pinot] branch master updated (fd0130b -> 8a3cecb)

2020-08-10 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from fd0130b Enhance sql parser for having and post-aggregation (#5825) add 8a3cecb [TE] frontend - harleyj

[GitHub] [incubator-pinot] bkuang88 commented on a change in pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
bkuang88 commented on a change in pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#discussion_r467344354 ## File path: pinot-core/src/test/java/org/apache/pinot/queries/DistinctCountThetaSketchTest.java ## @@ -117,60 +121,77 @@ public void testGroup

[incubator-pinot] branch master updated (6085578 -> fd0130b)

2020-08-10 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 6085578 Enable segment decryption for encrypted segments in Minion (#5821) add fd0130b Enhance sql p

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5825: Enhance sql parser for having and post-aggregation

2020-08-10 Thread GitBox
Jackie-Jiang merged pull request #5825: URL: https://github.com/apache/incubator-pinot/pull/5825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
mayankshriv commented on pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#issuecomment-671498383 > can we chain the operations? > > `diff(union($1, $2), union($3, $4)) ` Yes, the PR should already support this. @bkuang88 could you add a test for thi

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r468077683 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,63 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r468066337 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,87 @@

[incubator-pinot] branch master updated (373ceb1 -> 6085578)

2020-08-10 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 373ceb1 Retire travis from CI for testing (#5834) add 6085578 Enable segment decryption for encrypte

[GitHub] [incubator-pinot] mayankshriv merged pull request #5821: Enable segment decryption for encrypted segments in Minion

2020-08-10 Thread GitBox
mayankshriv merged pull request #5821: URL: https://github.com/apache/incubator-pinot/pull/5821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5808: [TE] Dashboard Resource Refactor

2020-08-10 Thread GitBox
suvodeep-pyne commented on pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-671486383 Thanks @vincentchenjl The core idea of this refactor is to have a coherence between the url path and the Resource class. Why? Because the goal of Jersey Res

[GitHub] [incubator-pinot] kishoreg edited a comment on pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
kishoreg edited a comment on pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#issuecomment-671441879 can we chain the operations? `diff(union($1, $2), union($3, $4)) ` This is an automated m

[GitHub] [incubator-pinot] kishoreg commented on pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-10 Thread GitBox
kishoreg commented on pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832#issuecomment-671441879 can we chain the operations? > diff(union($1, $2), union($3, $4)) This is an automated message

[GitHub] [incubator-pinot] KKcorps commented on pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-10 Thread GitBox
KKcorps commented on pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836#issuecomment-671259746 @fx19880617 @npawar This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-pinot] KKcorps opened a new pull request #5836: Fix ingesting data from Amazon S3 bucket

2020-08-10 Thread GitBox
KKcorps opened a new pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836 This PR fixes the issue #5835 of ingesting data from S3. The fix involves the following changes - Return full paths along with scheme in listFiles functions instead of path after

[GitHub] [incubator-pinot] itziklavon opened a new issue #5835: Problem when streaming data from S3 - 'Bucket' not found

2020-08-10 Thread GitBox
itziklavon opened a new issue #5835: URL: https://github.com/apache/incubator-pinot/issues/5835 having problem syncing data from s3 ``` Caused by: java.lang.IllegalArgumentException: Parameter 'Bucket' must not be null at software.amazon.awssdk.protocols.xml.internal.marshall

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r467732477 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,87 @@ privat

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee commented on a change in pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828#discussion_r467732477 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java ## @@ -177,4 +193,87 @@ privat