Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-25 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2499589720 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-25 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2499588139 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-25 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2499531153 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2484838475 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-18 Thread via GitHub
github-actions[bot] commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2484838424 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-13 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2472845591 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1838178552 ## cloud/src/meta-service/meta_service.cpp: ## @@ -1418,6 +1418,108 @@ static bool try_fetch_and_parse_schema(Transaction* txn, RowsetMetaCloudPB& rows

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-12 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2470636616 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-11 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2469751889 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-11 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1836742066 ## be/src/olap/tablet.cpp: ## @@ -955,6 +955,20 @@ Status Tablet::capture_rs_readers(const Version& spec_version, std::vector& sub_txn_ids, +

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-11 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1836736750 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -1743,6 +1745,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { @Va

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-11 Thread via GitHub
dataroaring commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2468249469 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1833623986 ## be/src/olap/base_tablet.cpp: ## @@ -129,6 +129,42 @@ BaseTablet::~BaseTablet() { g_total_tablet_num << -1; } +Status BaseTablet::capture_sub_txn_

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-07 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2463638805 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-11-03 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2453722160 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-31 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2449278104 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-30 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2448969094 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-27 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2440439517 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-24 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2434546947 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-23 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2434098261 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-18 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2422410829 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-18 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2421783040 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-12 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2408432294 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-11 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2408334627 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-11 Thread via GitHub
github-actions[bot] commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1797541896 ## be/src/olap/tablet_reader.cpp: ## @@ -207,8 +207,12 @@ Status TabletReader::_capture_rs_readers(const ReaderParams& read_params) { } i

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-10-09 Thread via GitHub
morrySnow commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1794613107 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneEmptyPartition.java: ## @@ -18,30 +18,59 @@ package org.apache.doris.nereids.rules.rewrite;

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778658006 ## cloud/src/meta-service/meta_service.cpp: ## @@ -1410,6 +1410,108 @@ static bool try_fetch_and_parse_schema(Transaction* txn, RowsetMetaCloudPB& rows return

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778696929 ## be/src/cloud/cloud_tablet.cpp: ## @@ -108,6 +108,44 @@ Status CloudTablet::capture_rs_readers(const Version& spec_version, return capture_rs_readers_unlock

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778712359 ## fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionEntry.java: ## @@ -534,4 +532,82 @@ private TTxnLoadInfo getTxnLoadInfo() { private Set get

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778640366 ## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ## @@ -1743,6 +1745,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { @Va

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778695195 ## be/src/olap/tablet.cpp: ## @@ -938,6 +938,38 @@ Status Tablet::capture_rs_readers(const Version& spec_version, std::vector& sub_txn_ids, +

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778652147 ## fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java: ## @@ -802,13 +802,27 @@ private void addScanRangeLocations(Partition partition,

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778655188 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneEmptyPartition.java: ## @@ -18,30 +18,59 @@ package org.apache.doris.nereids.rules.rewrite;

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-27 Thread via GitHub
dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1778652147 ## fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java: ## @@ -802,13 +802,27 @@ private void addScanRangeLocations(Partition partition,

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-26 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2378494786 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-26 Thread via GitHub
mymeiyi commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2376652470 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improve](txn insert) make sub transactions visible [doris]

2024-09-26 Thread via GitHub
doris-robot commented on PR #41362: URL: https://github.com/apache/doris/pull/41362#issuecomment-2376638651 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y