dataroaring commented on code in PR #41362: URL: https://github.com/apache/doris/pull/41362#discussion_r1836742066
########## be/src/olap/tablet.cpp: ########## @@ -955,6 +955,20 @@ Status Tablet::capture_rs_readers(const Version& spec_version, std::vector<RowSe return Status::OK(); } +Status Tablet::capture_sub_txn_rowsets(const std::vector<int64_t>& sub_txn_ids, + std::vector<RowsetSharedPtr>* rowsets) { + for (int i = 0; i < sub_txn_ids.size(); ++i) { + auto sub_txn_id = sub_txn_ids[i]; + auto rowset = _engine.txn_manager()->get_tablet_rowset(tablet_id(), tablet_uid(), + partition_id(), sub_txn_id); Review Comment: handle nullptr here to avoid that a bug resulting in a core dump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org