Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041309850 ## be/src/olap/id_manager.h: ## @@ -45,13 +45,22 @@ namespace doris { enum class FileMappingType { DORIS_FORMAT, // for doris format file {tablet_id}{rowset_i

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041163197 ## be/src/vec/exec/format/parquet/vparquet_reader.h: ## @@ -153,6 +153,15 @@ class ParquetReader : public GenericReader { _table_col_to_file_col = map;

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041174660 ## be/src/vec/exec/scan/vfile_scanner.cpp: ## @@ -1156,41 +1087,216 @@ Status VFileScanner::_get_next_reader() { return Status::InternalError("failed to

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041162318 ## be/src/vec/exec/format/parquet/vparquet_group_reader.cpp: ## @@ -751,6 +755,38 @@ Status RowGroupReader::_read_empty_batch(size_t batch_size, size_t* read_rows, b

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041174660 ## be/src/vec/exec/scan/vfile_scanner.cpp: ## @@ -1156,41 +1087,216 @@ Status VFileScanner::_get_next_reader() { return Status::InternalError("failed to

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041160508 ## be/src/vec/exec/format/orc/vorc_reader.cpp: ## @@ -1176,6 +1178,9 @@ Status OrcReader::set_fill_columns( } _row_reader = _reader->createRowReader

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041128256 ## be/src/vec/exec/format/orc/vorc_reader.cpp: ## @@ -1864,7 +1881,7 @@ std::string OrcReader::get_field_name_lower_case(const orc::Type* orc_type, int Status Orc

Re: [PR] impl external be [doris]

2025-04-13 Thread via GitHub
HappenLee commented on code in PR #49944: URL: https://github.com/apache/doris/pull/49944#discussion_r2041103824 ## be/src/olap/id_manager.h: ## @@ -83,6 +105,17 @@ struct FileMapping { return std::make_tuple(tablet_id, rowset_id, segment_id); } + +std::tuple

[PR] impl external be [doris]

2025-04-10 Thread via GitHub
hubgeter opened a new pull request, #49944: URL: https://github.com/apache/doris/pull/49944 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test

Re: [PR] impl external be [doris]

2025-04-09 Thread via GitHub
Thearas commented on PR #49944: URL: https://github.com/apache/doris/pull/49944#issuecomment-2791669264 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y