HappenLee commented on code in PR #49944:
URL: https://github.com/apache/doris/pull/49944#discussion_r2041309850
##########
be/src/olap/id_manager.h:
##########
@@ -45,13 +45,22 @@ namespace doris {
enum class FileMappingType {
DORIS_FORMAT, // for doris format file {tablet_id}{rowset_id}{segment_id}
- ORC,
- PARQUET
+ EXTERNAL, //
+};
+
+struct ExternalFileMappingInfo {
+ TFileRangeDesc external_scan_range_desc;
+ bool enable_file_meta_cache;
+
+ ExternalFileMappingInfo(const TFileRangeDesc& scan_range, bool
file_meta_cache):
+ external_scan_range_desc(scan_range),
enable_file_meta_cache(file_meta_cache) {
+ }
};
struct FileMapping {
FileMappingType type;
std::string value;
+ std::optional<ExternalFileMappingInfo> external_info = std::nullopt;
Review Comment:
better be a variant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
