Re: [PR] Use DorisVector to avoid memory usage from not being traced [doris]

2024-10-09 Thread via GitHub
yiguolei merged PR #41557: URL: https://github.com/apache/doris/pull/41557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] Use DorisVector to avoid memory usage from not being traced [doris]

2024-10-08 Thread via GitHub
yiguolei commented on code in PR #41557: URL: https://github.com/apache/doris/pull/41557#discussion_r1792879102 ## be/src/vec/common/hash_table/hash_map_context.h: ## @@ -243,14 +243,15 @@ struct MethodSerialized : public MethodBase { } for (const aut

Re: [PR] Use DorisVector to avoid memory usage from not being traced [doris]

2024-10-08 Thread via GitHub
yiguolei commented on code in PR #41557: URL: https://github.com/apache/doris/pull/41557#discussion_r1792692320 ## be/src/pipeline/exec/aggregation_source_operator.cpp: ## @@ -53,6 +53,9 @@ Status AggLocalState::init(RuntimeState* state, LocalStateInfo& info) { _hash_table

Re: [PR] Use DorisVector to avoid memory usage from not being traced [doris]

2024-10-08 Thread via GitHub
yiguolei commented on code in PR #41557: URL: https://github.com/apache/doris/pull/41557#discussion_r1792692054 ## be/src/vec/common/custom_allocator.h: ## @@ -23,8 +23,8 @@ template > class CustomStdAllocator; -template -using DorisVector = std::vector>; +template Review