yiguolei commented on code in PR #41557:
URL: https://github.com/apache/doris/pull/41557#discussion_r1792879102
##########
be/src/vec/common/hash_table/hash_map_context.h:
##########
@@ -243,14 +243,15 @@ struct MethodSerialized : public MethodBase<TData> {
}
for (const auto& column : key_columns) {
- column->serialize_vec(input_keys, num_rows,
max_one_row_byte_size);
+ column->serialize_vec(input_keys.data(), num_rows,
max_one_row_byte_size);
}
}
Base::keys = input_keys.data();
}
size_t serialized_keys_size(bool is_build) const override {
- return is_build ? build_arena.size() : Base::arena.size();
+ return is_build ? (build_stored_keys.size() * sizeof(StringRef))
+ : (stored_keys.size() * sizeof(StringRef));
Review Comment:
感觉这个不对吧，这个计算的偏小了。应该加上arena
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
