eldenmoon merged PR #45947:
URL: https://github.com/apache/doris/pull/45947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1904013486
##
be/src/vec/columns/column_object.cpp:
##
@@ -1297,27 +1295,12 @@ void ColumnObject::add_nested_subcolumn(const
PathInData& key, const FieldInfo&
}
void Column
csun5285 commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903967266
##
be/src/vec/columns/column_object.cpp:
##
@@ -834,6 +849,30 @@ void ColumnObject::check_consistency() const {
"unmatched sparse colum
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903933977
##
be/src/vec/columns/column_object.cpp:
##
@@ -2083,6 +2174,7 @@ void ColumnObject::clear_column_data() {
void ColumnObject::clear() {
Subcolumns empty;
+
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903932813
##
be/src/vec/columns/column_object.cpp:
##
@@ -1965,12 +2046,18 @@ Status ColumnObject::finalize(FinalizeMode mode) {
for (auto&& entry : subcolumns) {
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903931132
##
be/src/vec/columns/column_object.cpp:
##
@@ -1279,6 +1337,10 @@ void ColumnObject::insert_range_from(const IColumn& src,
size_t start, size_t le
std::map
sr
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903930372
##
be/src/vec/columns/column_object.cpp:
##
@@ -1457,6 +1518,8 @@ size_t
ColumnObject::Subcolumn::serialize_text_json(size_t n, BufferWritable& ou
ind -= num_
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903928475
##
be/src/vec/columns/column_object.cpp:
##
@@ -1262,10 +1296,34 @@ void ColumnObject::add_nested_subcolumn(const
PathInData& key, const FieldInfo&
ENABLE_CHECK
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903928475
##
be/src/vec/columns/column_object.cpp:
##
@@ -1262,10 +1296,34 @@ void ColumnObject::add_nested_subcolumn(const
PathInData& key, const FieldInfo&
ENABLE_CHECK
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903927450
##
be/src/vec/columns/column_object.cpp:
##
@@ -1262,10 +1296,34 @@ void ColumnObject::add_nested_subcolumn(const
PathInData& key, const FieldInfo&
ENABLE_CHECK
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903927097
##
be/src/vec/columns/column_object.cpp:
##
@@ -905,17 +945,11 @@ void ColumnObject::try_insert(const Field& field) {
// Insert to an emtpy ColumnObject may
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903792725
##
be/src/vec/columns/column_object.cpp:
##
@@ -834,6 +849,30 @@ void ColumnObject::check_consistency() const {
"unmatched sparse colu
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903926154
##
be/src/vec/columns/column_object.cpp:
##
@@ -663,10 +675,10 @@ void ColumnObject::resize(size_t n) {
}
void ColumnObject::Subcolumn::finalize(FinalizeMode mode
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903925840
##
be/src/vec/columns/column_object.cpp:
##
@@ -352,20 +352,28 @@ void get_field_info(const Field& field, FieldInfo* info) {
}
#ifdef NDEBUG
-#define ENABLE_CHECK
eldenmoon commented on code in PR #45947:
URL: https://github.com/apache/doris/pull/45947#discussion_r1903792725
##
be/src/vec/columns/column_object.cpp:
##
@@ -834,6 +849,30 @@ void ColumnObject::check_consistency() const {
"unmatched sparse colu
csun5285 opened a new pull request, #45947:
URL: https://github.com/apache/doris/pull/45947
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test
hello-stephen commented on PR #45947:
URL: https://github.com/apache/doris/pull/45947#issuecomment-2561864009
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro
17 matches
Mail list logo
