csun5285 commented on code in PR #45947: URL: https://github.com/apache/doris/pull/45947#discussion_r1903967266
########## be/src/vec/columns/column_object.cpp: ########## @@ -834,6 +849,30 @@ void ColumnObject::check_consistency() const { "unmatched sparse column:, expeted rows: {}, but meet: {}", num_rows, serialized_sparse_column->size()); } + + bool error = false; + auto [path, value] = get_sparse_data_paths_and_values(); Review Comment: done ########## be/src/vec/columns/column_object.cpp: ########## @@ -352,20 +352,28 @@ void get_field_info(const Field& field, FieldInfo* info) { } #ifdef NDEBUG -#define ENABLE_CHECK_CONSISTENCY (void) /* Nothing */ +#define ENABLE_CHECK_CONSISTENCY (void)/* Nothing */ #else #define ENABLE_CHECK_CONSISTENCY(this) (this)->check_consistency() #endif // current nested level is 2, inside column object constexpr int CURRENT_SERIALIZE_NESTING_LEVEL = 2; +DataTypeSerDeSPtr ColumnObject::Subcolumn::generate_data_serdes(DataTypePtr type, bool is_root) { + if (is_root) { + return type->get_serde(CURRENT_SERIALIZE_NESTING_LEVEL - 1); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org