morningman merged PR #38560:
URL: https://github.com/apache/doris/pull/38560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270745528
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270350998
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
superdiaodiao commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1704886123
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -257,63 +254,38 @@ class FunctionArrayDistinct : public IFunction {
ICol
superdiaodiao commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1704886279
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -257,64 +254,41 @@ class FunctionArrayDistinct : public IFunction {
ICol
superdiaodiao commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1704885268
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -257,63 +254,38 @@ class FunctionArrayDistinct : public IFunction {
ICol
github-actions[bot] commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270314048
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270314016
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270313589
ClickBench: Total hot run time: 30.49 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
lide-reed commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1699287705
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -257,63 +254,38 @@ class FunctionArrayDistinct : public IFunction {
IColumn&
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270309650
TPC-DS: Total hot run time: 168523 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270302044
TPC-H: Total hot run time: 41951 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2270270140
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2268856574
ClickBench: Total hot run time: 30.18 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2268846028
TPC-DS: Total hot run time: 170134 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2268827101
TPC-H: Total hot run time: 41807 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2268756929
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262717905
run cloud_p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262714793
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262707836
run cloud_p0, run cloud_p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262653650
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262652871
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262143406
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262142806
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262141685
run p0, run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262137500
run p0
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262037304
ClickBench: Total hot run time: 29.84 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262031863
TPC-DS: Total hot run time: 169596 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2262021902
TPC-H: Total hot run time: 41350 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
superdiaodiao commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1699373360
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -257,63 +254,38 @@ class FunctionArrayDistinct : public IFunction {
ICol
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2261962664
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cambyzju commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1699297328
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -257,63 +254,38 @@ class FunctionArrayDistinct : public IFunction {
IColumn&
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259834267
ClickBench: Total hot run time: 30.31 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259826094
TPC-DS: Total hot run time: 169425 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259809070
TPC-H: Total hot run time: 42023 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259766446
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
superdiaodiao commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259717026
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259714736
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1697883839
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -19,14 +19,11 @@
// and modified by Doris
#pragma once
-#include
#include
Review Comm
github-actions[bot] commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1697874796
##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -21,12 +21,10 @@
#include
Review Comment:
warning: 'fmt/format.h' file not found [cla
doris-robot commented on PR #38560:
URL: https://github.com/apache/doris/pull/38560#issuecomment-2259606081
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
superdiaodiao opened a new pull request, #38560:
URL: https://github.com/apache/doris/pull/38560
## Proposed changes
Issue Number: close #xxx
refactor part of BE code of `array_distinct` function by:
1. optimize the head files
2. use type deduction(auto)
3. use macr
42 matches
Mail list logo
