superdiaodiao commented on code in PR #38560:
URL: https://github.com/apache/doris/pull/38560#discussion_r1704886123
##########
be/src/vec/functions/array/function_array_distinct.h:
##########
@@ -257,63 +254,38 @@ class FunctionArrayDistinct : public IFunction {
IColumn& dest_column, ColumnArray::Offsets64&
dest_offsets,
const NullMapType* src_null_map, NullMapType*
dest_null_map,
DataTypePtr& nested_type) const {
+#define EXECUTE_NUMBER(TYPE, NAME)
\
+ if (which.is_##NAME()) {
\
+ res = _execute_number<TYPE>(src_column, src_offsets, dest_column,
dest_offsets, \
+ src_null_map, dest_null_map);
\
+ } else
+
Review Comment:
OK.
##########
be/src/vec/functions/array/function_array_distinct.h:
##########
@@ -254,13 +254,12 @@ class FunctionArrayDistinct : public IFunction {
IColumn& dest_column, ColumnArray::Offsets64&
dest_offsets,
const NullMapType* src_null_map, NullMapType*
dest_null_map,
DataTypePtr& nested_type) const {
-#define EXECUTE_NUMBER(TYPE, NAME)
\
- if (which.is_##NAME()) {
\
- res = _execute_number<TYPE>(src_column, src_offsets, dest_column,
dest_offsets, \
- src_null_map, dest_null_map);
\
+#define EXECUTE_NUMBER(TYPE, NAME)
\
+ if (which.is_##NAME()) {
\
+ return _execute_number<TYPE>(src_column, src_offsets, dest_column,
dest_offsets, \
+ src_null_map, dest_null_map);
\
} else
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
