Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-12-12 Thread via GitHub
0xderek commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2539464746 > > Hi, > > I am working on a patch to fix #42406. Initially I came across the issue on Doris 2.1.6 so I based my work on branch-2.1. I added some tests in be/test/vec/data_types/serde

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-12-09 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2530033726 > Hi, > > I am working on a patch to fix #42406. Initially I came across the issue on Doris 2.1.6 so I based my work on branch-2.1. I added some tests in be/test/vec/data_types/s

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-11-12 Thread via GitHub
0xderek commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2471280439 HI, I am working on a patch to fix #42406. Initially I came across the issue on Doris 2.1.6 so I based my work on branch-2.1. I added some tests in be/test/vec/data_types/serde/da

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 merged PR #42992: URL: https://github.com/apache/doris/pull/42992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449837305 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449407693 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
doris-robot commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449604253 TeamCity be ut coverage result: Function Coverage: 37.81% (9816/25959) Line Coverage: 29.01% (81574/281152) Region Coverage: 28.28% (42120/148931) Branch Coverage: 24.8

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449569143 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449558345 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449431221 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449456310 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449456264 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449442189 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449373851 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449396676 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449361439 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
doris-robot commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449176370 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449186879 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
github-actions[bot] commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449183956 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449178210 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2449176420 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [refactor](metrics) Complete metrics for some operators [doris]

2024-10-31 Thread via GitHub
Gabriel39 opened a new pull request, #42992: URL: https://github.com/apache/doris/pull/42992 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a