Gabriel39 commented on PR #42992: URL: https://github.com/apache/doris/pull/42992#issuecomment-2530033726
> Hi, > > I am working on a patch to fix #42406. Initially I came across the issue on Doris 2.1.6 so I based my work on branch-2.1. I added some tests in be/test/vec/data_types/serde/data_type_serde_arrow_test.cpp but I can't find the file on master branch. > > It turns out the file was removed in this pull request. It seems odd to me as the test file is irrelevant to this pr. Is there a particular reason to remove it? > > Thanks. Hi @0xderek , sorry for this late reply. I removed this file because I found a function `convert_to_arrow_schema` which is never unused is tested multiple times by this test file. In this PR, I deleted this unused function and also removed this file. And after discussing with @xinyiZzz , we think this file needs to be refactored to do some necessary tests. This job is expected to be done in this month. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
