morningman merged PR #34873:
URL: https://github.com/apache/doris/pull/34873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.a
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2123814605
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2123814641
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2121578646
TeamCity be ut coverage result:
Function Coverage: 35.68% (9012/25259)
Line Coverage: 27.33% (74514/272616)
Region Coverage: 26.58% (38538/144990)
Branch Coverage: 23.4
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2121545789
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AshinGau commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2121538378
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2121493783
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AshinGau commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2121487949
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
doris-robot commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2119616410
TeamCity be ut coverage result:
Function Coverage: 35.69% (9006/25236)
Line Coverage: 27.35% (74491/272314)
Region Coverage: 26.59% (38524/144858)
Branch Coverage: 23.4
AshinGau commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2119586921
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
w41ter commented on code in PR #34873:
URL: https://github.com/apache/doris/pull/34873#discussion_r1606197209
##
be/src/olap/wal/wal_reader.cpp:
##
@@ -50,11 +50,8 @@ Status WalReader::init() {
}
Status WalReader::finalize() {
-if (file_reader != nullptr) {
-auto
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2119503302
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
morningman commented on code in PR #34873:
URL: https://github.com/apache/doris/pull/34873#discussion_r1604645115
##
be/src/olap/wal/wal_reader.cpp:
##
@@ -50,11 +50,8 @@ Status WalReader::init() {
}
Status WalReader::finalize() {
-if (file_reader != nullptr) {
-
doris-robot commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2117092517
TeamCity be ut coverage result:
Function Coverage: 35.69% (9005/25234)
Line Coverage: 27.37% (74520/272297)
Region Coverage: 26.61% (38536/144835)
Branch Coverage: 23.4
AshinGau commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2117024949
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2116918665
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2113721702
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2113627622
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2111425253
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #34873:
URL: https://github.com/apache/doris/pull/34873#issuecomment-2111420537
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
AshinGau opened a new pull request, #34873:
URL: https://github.com/apache/doris/pull/34873
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto
21 matches
Mail list logo
