morningman commented on code in PR #34873:
URL: https://github.com/apache/doris/pull/34873#discussion_r1604645115
##########
be/src/olap/wal/wal_reader.cpp:
##########
@@ -50,11 +50,8 @@ Status WalReader::init() {
}
Status WalReader::finalize() {
- if (file_reader != nullptr) {
- auto st = file_reader->close();
- if (!st.ok()) {
- LOG(WARNING) << "fail to close wal " << _file_name << " st= " <<
st.to_string();
- }
+ if (file_reader) {
+ return file_reader->close();
Review Comment:
@w41ter PTAL, I not sure why we ignore the error before
##########
be/src/vec/exec/format/table/max_compute_jni_reader.h:
##########
@@ -68,6 +68,13 @@ class MaxComputeJniReader : public GenericReader {
Status init_reader(
std::unordered_map<std::string, ColumnValueRangeType>*
colname_to_value_range);
+ Status close() override {
Review Comment:
Same as parent, no need to override
##########
be/src/vec/exec/format/avro/avro_jni_reader.h:
##########
@@ -85,6 +85,13 @@ class AvroJNIReader : public GenericReader {
TypeDescriptor convert_complex_type(const rapidjson::Document::ConstObject
child_schema);
+ Status close() override {
Review Comment:
Same as parent, no need to override
##########
be/src/vec/exec/format/table/trino_connector_jni_reader.h:
##########
@@ -61,6 +61,13 @@ class TrinoConnectorJniReader : public GenericReader {
Status init_reader(
std::unordered_map<std::string, ColumnValueRangeType>*
colname_to_value_range);
+ Status close() override {
Review Comment:
ditto
##########
be/src/vec/exec/format/table/hudi_jni_reader.h:
##########
@@ -63,6 +63,13 @@ class HudiJniReader : public GenericReader {
Status init_reader(
std::unordered_map<std::string, ColumnValueRangeType>*
colname_to_value_range);
+ Status close() override {
Review Comment:
Same as parent, no need to override
##########
be/src/vec/exec/format/table/paimon_reader.h:
##########
@@ -66,6 +66,13 @@ class PaimonJniReader : public GenericReader {
Status init_reader(
std::unordered_map<std::string, ColumnValueRangeType>*
colname_to_value_range);
+ Status close() override {
Review Comment:
Same as parent, no need to override
##########
be/src/vec/exec/format/wal/wal_reader.cpp:
##########
@@ -30,12 +30,6 @@ WalReader::WalReader(RuntimeState* state) : _state(state) {
_wal_id = state->wal_id();
}
-WalReader::~WalReader() {
Review Comment:
@w41ter PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
