Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-20 Thread via GitHub
Gabriel39 merged PR #44272: URL: https://github.com/apache/doris/pull/44272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-20 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2489913451 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-20 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2485211646 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2487727833 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2487723933 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
Gabriel39 commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2487715571 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2487342773 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
Gabriel39 commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2487309950 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
Gabriel39 commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2485152103 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2485211562 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44272: URL: https://github.com/apache/doris/pull/44272#discussion_r1848007713 ## be/src/vec/columns/column.h: ## @@ -256,12 +256,6 @@ class IColumn : public COW { "Method insert_many_dict_data is not supported fo

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
yiguolei commented on code in PR #44272: URL: https://github.com/apache/doris/pull/44272#discussion_r1848006866 ## be/src/vec/columns/column.h: ## @@ -256,12 +256,6 @@ class IColumn : public COW { "Method insert_many_dict_data is not supported fo

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
github-actions[bot] commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2485154423 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
doris-robot commented on PR #44272: URL: https://github.com/apache/doris/pull/44272#issuecomment-2485143289 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+proce

[PR] [refactor](column) Simplify column functions [doris]

2024-11-19 Thread via GitHub
Gabriel39 opened a new pull request, #44272: URL: https://github.com/apache/doris/pull/44272 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Tes