yiguolei commented on code in PR #44272:
URL: https://github.com/apache/doris/pull/44272#discussion_r1848007713
##########
be/src/vec/columns/column.h:
##########
@@ -256,12 +256,6 @@ class IColumn : public COW<IColumn> {
"Method insert_many_dict_data is not supported
for " + get_name());
}
- virtual void insert_many_binary_data(char* data_array, uint32_t* len_array,
- uint32_t* start_offset_array, size_t
num) {
- throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
- "Method insert_many_binary_data is not
supported for " + get_name());
- }
-
/// Insert binary data into column from a continuous buffer, the
implementation maybe copy all binary data
/// in one single time.
virtual void insert_many_continuous_binary_data(const char* data, const
uint32_t* offsets,
Review Comment:
also modify this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
