Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-09 Thread via GitHub
dataroaring merged PR #37165: URL: https://github.com/apache/doris/pull/37165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-08 Thread via GitHub
github-actions[bot] commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2213194845 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-08 Thread via GitHub
github-actions[bot] commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2213194889 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2211134273 ClickBench: Total hot run time: 30.92 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2211128194 TPC-DS: Total hot run time: 170447 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
doris-robot commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-224656 TPC-H: Total hot run time: 39939 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
dataroaring commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2211000842 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
platoneko commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2210547272 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
gavinchou commented on code in PR #37165: URL: https://github.com/apache/doris/pull/37165#discussion_r1666514225 ## be/CMakeLists.txt: ## @@ -118,6 +118,7 @@ set(BASE_DIR "${CMAKE_CURRENT_SOURCE_DIR}") set(ENV{DORIS_HOME} "${BASE_DIR}/..") set(BUILD_DIR "${CMAKE_CURRENT_BINARY

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-05 Thread via GitHub
platoneko commented on code in PR #37165: URL: https://github.com/apache/doris/pull/37165#discussion_r1666454425 ## common_cpp/sync_point.h: ## @@ -259,15 +259,12 @@ auto try_any_cast_ret(std::vector& any) { # define TEST_INJECTION_POINT_RETURN_WITH_VOID(x, ...) # define TEST_

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-02 Thread via GitHub
w41ter commented on code in PR #37165: URL: https://github.com/apache/doris/pull/37165#discussion_r1663439424 ## common_cpp/CMakeLists.txt: ## Review Comment: How about naming it as `common/rock` and setting the include directory to `common`, then the user would locate and

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-02 Thread via GitHub
w41ter commented on code in PR #37165: URL: https://github.com/apache/doris/pull/37165#discussion_r1663439424 ## common_cpp/CMakeLists.txt: ## Review Comment: How about naming it as `common/rock` and setting the include directory to `common`, then the user would locate and

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-02 Thread via GitHub
doris-robot commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2203274657 ClickBench: Total hot run time: 30.16 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-02 Thread via GitHub
doris-robot commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2203206715 TPC-H: Total hot run time: 40765 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [refactor](cloud) Extract SyncPoint to common cpp [doris]

2024-07-02 Thread via GitHub
doris-robot commented on PR #37165: URL: https://github.com/apache/doris/pull/37165#issuecomment-2203249623 TPC-DS: Total hot run time: 174542 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS