w41ter commented on code in PR #37165: URL: https://github.com/apache/doris/pull/37165#discussion_r1663439424
########## common_cpp/CMakeLists.txt: ########## Review Comment: How about naming it as `common/rock` and setting the include directory to `common`, then the user would locate and identify the included files by `#include "rock/sync_point.h"`. The word `rock` is just an example, it could be other words. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
