Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713490328 ClickBench: Total hot run time: 31.28 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
yiguolei merged PR #48750: URL: https://github.com/apache/doris/pull/48750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713803802 # BE UT Coverage Report Increment line coverage `50.00% (10/20)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/9119e63a6b962c1f647bcafd74a5398a3b

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
github-actions[bot] commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713742037 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
zhiqiang- commented on code in PR #48750: URL: https://github.com/apache/doris/pull/48750#discussion_r1988641950 ## be/src/util/threadpool.cpp: ## @@ -47,7 +47,9 @@ DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_queue_size, MetricUnit::NOUNI DEFINE_GAUGE_METRIC_PROTOTY

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
github-actions[bot] commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713741850 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713472691 TPC-DS: Total hot run time: 185639 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713427401 TPC-H: Total hot run time: 32655 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
zhiqiang- commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2713176669 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
zhiqiang- commented on code in PR #48750: URL: https://github.com/apache/doris/pull/48750#discussion_r1988704657 ## be/src/util/threadpool.cpp: ## @@ -47,7 +47,9 @@ DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_queue_size, MetricUnit::NOUNI DEFINE_GAUGE_METRIC_PROTOTY

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-11 Thread via GitHub
yiguolei commented on code in PR #48750: URL: https://github.com/apache/doris/pull/48750#discussion_r1988635557 ## be/src/util/threadpool.cpp: ## @@ -47,7 +47,9 @@ DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_queue_size, MetricUnit::NOUNI DEFINE_GAUGE_METRIC_PROTOTYPE_2A

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2703575723 # BE UT Coverage Report Increment line coverage `50.00% (4/8)` :tada: [Increment coverage report](http://coverage.selectdb-in.cc/coverage/6d86428d5648259e2f93746c131c3d577e0c

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2703402221 ClickBench: Total hot run time: 31.53 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2703389039 TPC-DS: Total hot run time: 192213 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
doris-robot commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2703358085 TPC-H: Total hot run time: 32670 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
Thearas commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2703162270 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
zhiqiang- commented on PR #48750: URL: https://github.com/apache/doris/pull/48750#issuecomment-2703162852 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [opt](metrics) More precise task execution and wait worker time [doris]

2025-03-06 Thread via GitHub
zhiqiang- opened a new pull request, #48750: URL: https://github.com/apache/doris/pull/48750 ### What problem does this PR solve? Add `task_execution_count_total` and `task_wait_worker_count_total = nullptr`. We can calculate avg task execution time and avg wait worker time