yiguolei commented on code in PR #48750: URL: https://github.com/apache/doris/pull/48750#discussion_r1988635557
########## be/src/util/threadpool.cpp: ########## @@ -47,7 +47,9 @@ DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_queue_size, MetricUnit::NOUNI DEFINE_GAUGE_METRIC_PROTOTYPE_2ARG(thread_pool_max_threads, MetricUnit::NOUNIT); DEFINE_COUNTER_METRIC_PROTOTYPE_2ARG(thread_pool_submit_failed, MetricUnit::NOUNIT); DEFINE_COUNTER_METRIC_PROTOTYPE_2ARG(task_execution_time_ns_total, MetricUnit::NANOSECONDS); Review Comment: thread pool 相关的监控，都要以thread_pool_ 开头，否则我们不知道这个task 是scan task，pipelinetask 还是啥。task 这种太通用了。 其他thread pool 相关的指标，也都改一下。趁着我们还没做grafana dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
