Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2025-01-16 Thread via GitHub
github-actions[bot] closed pull request #37592: [opt](cast) use fmt in cast float to string URL: https://github.com/apache/doris/pull/37592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2025-01-15 Thread via GitHub
github-actions[bot] commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2594188126 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-19 Thread via GitHub
github-actions[bot] commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2238606880 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-19 Thread via GitHub
Mryange commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2238480103 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-19 Thread via GitHub
Mryange commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2238596989 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-18 Thread via GitHub
github-actions[bot] commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2238489532 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-11 Thread via GitHub
HappenLee commented on code in PR #37592: URL: https://github.com/apache/doris/pull/37592#discussion_r1675100985 ## be/src/vec/data_types/data_type_number.cpp: ## @@ -47,10 +47,6 @@ void DataTypeNumber::push_bumber(ColumnString::Chars& chars, const T& num) co if constexpr

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2219807292 ClickBench: Total hot run time: 31.25 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2219796986 TPC-DS: Total hot run time: 174871 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2219777274 TPC-H: Total hot run time: 39806 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-10 Thread via GitHub
Mryange commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2219713908 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-10 Thread via GitHub
Mryange opened a new pull request, #37592: URL: https://github.com/apache/doris/pull/37592 ## Proposed changes before ``` mysql [test10]>select cast(f64 as string) from nums; +--+ | ReturnedRows | +--+ | 2000 | +--+ 1

Re: [PR] [opt](cast) use fmt in cast float to string [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37592: URL: https://github.com/apache/doris/pull/37592#issuecomment-2219713379 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y