HappenLee commented on code in PR #37592:
URL: https://github.com/apache/doris/pull/37592#discussion_r1675100985
##########
be/src/vec/data_types/data_type_number.cpp:
##########
@@ -47,10 +47,6 @@ void DataTypeNumber<T>::push_bumber(ColumnString::Chars&
chars, const T& num) co
if constexpr (std::is_same<T, UInt128>::value) {
std::string hex = int128_to_string(num);
chars.insert(hex.begin(), hex.end());
- } else if constexpr (std::is_same_v<T, float>) {
- char buf[MAX_FLOAT_STR_LENGTH + 2];
- int len = FloatToBuffer(num, MAX_FLOAT_STR_LENGTH + 2, buf);
Review Comment:
check if we do not use `FloatToBuffer` func, delete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
