Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-12 Thread via GitHub
yiguolei merged PR #43212: URL: https://github.com/apache/doris/pull/43212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
yiguolei commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2469806374 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
github-actions[bot] commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2469789814 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1837571156 ## be/src/runtime/fragment_mgr.cpp: ## @@ -912,9 +915,18 @@ void FragmentMgr::cancel_worker() { LOG_WARNING("Query {} is timeout", print_id(i

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
mrhhsg commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2469512957 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
mrhhsg commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2468234983 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
doris-robot commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2467702496 TeamCity be ut coverage result: Function Coverage: 37.77% (9843/26058) Line Coverage: 29.05% (82294/283279) Region Coverage: 28.18% (42314/150158) Branch Coverage: 24.7

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-11 Thread via GitHub
mrhhsg commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2467545969 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-10 Thread via GitHub
mrhhsg commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2467461940 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2458672781 TeamCity be ut coverage result: Function Coverage: 37.85% (9837/25986) Line Coverage: 29.03% (81836/281926) Region Coverage: 28.26% (42163/149191) Branch Coverage: 24.8

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-05 Thread via GitHub
mrhhsg commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2458553698 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2457466819 TeamCity be ut coverage result: Function Coverage: 37.86% (9838/25986) Line Coverage: 29.03% (81841/281923) Region Coverage: 28.26% (42164/149188) Branch Coverage: 24.8

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-05 Thread via GitHub
yiguolei commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2457201818 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-05 Thread via GitHub
github-actions[bot] commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2457191152 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-05 Thread via GitHub
github-actions[bot] commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2457191074 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827567467 ## be/src/runtime/fragment_mgr.h: ## @@ -148,6 +148,11 @@ class FragmentMgr : public RestMonitorIface { std::shared_ptr get_or_erase_query_ctx_with_lock(const TU

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827550387 ## be/src/runtime/fragment_mgr.cpp: ## @@ -1034,10 +1050,55 @@ void FragmentMgr::cancel_worker() { "Source frontend is not runni

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827564757 ## be/src/runtime/fragment_mgr.cpp: ## @@ -1034,10 +1050,55 @@ void FragmentMgr::cancel_worker() { "Source frontend is not runni

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827561546 ## be/src/runtime/fragment_mgr.cpp: ## @@ -1034,10 +1050,55 @@ void FragmentMgr::cancel_worker() { "Source frontend is not runni

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827561546 ## be/src/runtime/fragment_mgr.cpp: ## @@ -1034,10 +1050,55 @@ void FragmentMgr::cancel_worker() { "Source frontend is not runni

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827550387 ## be/src/runtime/fragment_mgr.cpp: ## @@ -1034,10 +1050,55 @@ void FragmentMgr::cancel_worker() { "Source frontend is not runni

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827520378 ## be/src/runtime/fragment_mgr.cpp: ## @@ -909,6 +911,7 @@ void FragmentMgr::cancel_worker() { c->clear_finished_tasks(); } +std::unord

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827509184 ## be/src/runtime/query_context.h: ## @@ -20,6 +20,7 @@ #include Review Comment: warning: 'gen_cpp/PaloInternalService_types.h' file not found [clang

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
yiguolei commented on code in PR #43212: URL: https://github.com/apache/doris/pull/43212#discussion_r1827424925 ## be/src/runtime/fragment_mgr.cpp: ## @@ -631,6 +633,26 @@ std::shared_ptr FragmentMgr::get_or_erase_query_ctx_with_lock( return _get_or_erase_query_ctx(query_i

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2454177720 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43212: URL: https://github.com/apache/doris/pull/43212#issuecomment-2454168167 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [opt](brpc) check and remove unavailable brpc stubs [doris]

2024-11-04 Thread via GitHub
mrhhsg opened a new pull request, #43212: URL: https://github.com/apache/doris/pull/43212 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Check List (For Committer) - Test - [ ] Regr