yiguolei commented on code in PR #43212:
URL: https://github.com/apache/doris/pull/43212#discussion_r1827424925


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -631,6 +633,26 @@ std::shared_ptr<QueryContext> 
FragmentMgr::get_or_erase_query_ctx_with_lock(
     return _get_or_erase_query_ctx(query_id);
 }
 
+void FragmentMgr::register_brpc_with_query(const TNetworkAddress& 
network_address,
+                                           
std::shared_ptr<PBackendService_Stub> brpc_stub,
+                                           TUniqueId query_id) {
+    std::lock_guard<std::mutex> lock(_lock);

Review Comment:
   the lock will very very busy, we could save it in query context and collect 
it during cancel worker



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to