Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-21 Thread via GitHub
yiguolei merged PR #37990: URL: https://github.com/apache/doris/pull/37990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2238958990 ClickBench: Total hot run time: 31.04 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2238951472 TPC-DS: Total hot run time: 172333 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2238936227 TPC-H: Total hot run time: 40073 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
github-actions[bot] commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2238784475 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
github-actions[bot] commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2238784532 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
github-actions[bot] commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1684011702 ## be/src/vec/sink/vmysql_result_writer.cpp: ## @@ -140,23 +141,11 @@ Status VMysqlResultWriter::_set_options( } template -Status VMysqlResultWriter::w

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
mrhhsg commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2238610153 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
yiguolei commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1683963178 ## be/src/vec/sink/vmysql_result_writer.cpp: ## @@ -249,6 +237,47 @@ Status VMysqlResultWriter::write(RuntimeState* state, Block& i return status; } +template

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
yiguolei commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1683954105 ## be/src/vec/sink/vmysql_result_writer.cpp: ## @@ -249,6 +237,47 @@ Status VMysqlResultWriter::write(RuntimeState* state, Block& i return status; } +template

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
yiguolei commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1683954105 ## be/src/vec/sink/vmysql_result_writer.cpp: ## @@ -249,6 +237,47 @@ Status VMysqlResultWriter::write(RuntimeState* state, Block& i return status; } +template

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-19 Thread via GitHub
yiguolei commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1683949300 ## be/src/vec/sink/vmysql_result_writer.cpp: ## @@ -249,6 +237,47 @@ Status VMysqlResultWriter::write(RuntimeState* state, Block& i return status; } +template

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232639738 ClickBench: Total hot run time: 31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools Cli

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232629870 TPC-DS: Total hot run time: 173515 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232609880 TPC-H: Total hot run time: 40079 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
yiguolei commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1680548458 ## be/src/runtime/buffer_control_block.cpp: ## @@ -80,6 +81,13 @@ void GetResultBatchCtx::on_data(const std::unique_ptr& t_resul result->set_packet_seq(packe

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
github-actions[bot] commented on code in PR #37990: URL: https://github.com/apache/doris/pull/37990#discussion_r1680537939 ## be/src/vec/sink/vmysql_result_writer.cpp: ## @@ -140,23 +140,11 @@ Status VMysqlResultWriter::_set_options( } template -Status VMysqlResultWriter::w

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
mrhhsg commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232580557 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232579390 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]

2024-07-17 Thread via GitHub
mrhhsg opened a new pull request, #37990: URL: https://github.com/apache/doris/pull/37990 ## Proposed changes If the size of `PFetchDataResult` is greater than 2G, protocol buffer cannot serialize the message. -- This is an automated message from the Apache Git Service. To