Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-31 Thread via GitHub
BiteThet merged PR #30543: URL: https://github.com/apache/doris/pull/30543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-31 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1918651611 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 8ff51c7361a6854497cc8b5e972d3a0ae6368cc3 with default session variables Stream

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1917251676 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 6037e11643ac2e65e68cc32788c93970e89bfd14 with default session variables Stream

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1917235784 ClickBench: Total hot run time: 31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools Cli

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1917208519 TPC-DS: Total hot run time: 172152 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1917168403 TeamCity be ut coverage result: Function Coverage: 36.20% (8626/23832) Line Coverage: 28.26% (70548/249605) Region Coverage: 27.26% (36399/133540) Branch Coverage: 24.0

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1917153822 TPC-H: Total hot run time: 36851 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
github-actions[bot] commented on code in PR #30543: URL: https://github.com/apache/doris/pull/30543#discussion_r1471355997 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -370,8 +440,7 @@ Status ProcessHashTableProbe::do_mark_join_conjuncts( template Status P

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
mrhhsg commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1917007898 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916619070 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 9b45b271a0a0911056cfe0744e15352add1129c8 with default session variables Stream

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916623132 TeamCity be ut coverage result: Function Coverage: 36.24% (8637/23836) Line Coverage: 28.29% (70623/249678) Region Coverage: 27.29% (36459/133574) Branch Coverage: 24.0

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916614146 ClickBench: Total hot run time: 31.06 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916605370 TPC-DS: Total hot run time: 173653 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916585834 TPC-H: Total hot run time: 37312 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
github-actions[bot] commented on code in PR #30543: URL: https://github.com/apache/doris/pull/30543#discussion_r1470955686 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -246,7 +313,7 @@ Status ProcessHashTableProbe::do_process(HashTableType& hash template tem

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-30 Thread via GitHub
mrhhsg commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916501855 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916237005 TeamCity be ut coverage result: Function Coverage: 36.23% (8634/23828) Line Coverage: 28.28% (70598/249651) Region Coverage: 27.28% (36440/133564) Branch Coverage: 24.0

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916227050 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit baf67e32f2efce6e6d3787e3ff60ab41bb0408b5 with default session variables Stream

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916223504 ClickBench: Total hot run time: 30.91 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916215315 TPC-DS: Total hot run time: 171716 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916202817 TPC-H: Total hot run time: 36827 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
github-actions[bot] commented on code in PR #30543: URL: https://github.com/apache/doris/pull/30543#discussion_r1470659303 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -246,7 +286,7 @@ Status ProcessHashTableProbe::do_process(HashTableType& hash template tem

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
mrhhsg commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916163151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916083139 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 0556c5080b63febd6ecc8c363a36b0edea6e8181 with default session variables Stream

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916080584 ClickBench: Total hot run time: 30.08 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916076189 TPC-DS: Total hot run time: 172214 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916067594 TPC-H: Total hot run time: 37011 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916063329 TeamCity be ut coverage result: Function Coverage: 36.20% (8625/23827) Line Coverage: 28.26% (70537/249622) Region Coverage: 27.25% (36390/133554) Branch Coverage: 24.0

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
github-actions[bot] commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916037594 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
github-actions[bot] commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916034782 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
mrhhsg commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916029755 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
github-actions[bot] commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916024557 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916021569 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit c04918a12c8213338dc65b5b94b539a834da5c39 with default session variables Stream

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916019490 ClickBench: Total hot run time: 30.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916015743 TPC-DS: Total hot run time: 171973 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916013975 TeamCity be ut coverage result: Function Coverage: 36.20% (8625/23827) Line Coverage: 28.26% (70537/249627) Region Coverage: 27.25% (36389/133554) Branch Coverage: 24.0

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
doris-robot commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1916007627 TPC-H: Total hot run time: 36926 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
github-actions[bot] commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1915977462 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
mrhhsg commented on PR #30543: URL: https://github.com/apache/doris/pull/30543#issuecomment-1915960045 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] [fix](join) incorrect result of mark join [doris]

2024-01-29 Thread via GitHub
mrhhsg opened a new pull request, #30543: URL: https://github.com/apache/doris/pull/30543 ## Proposed change ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why y