github-actions[bot] commented on code in PR #30543:
URL: https://github.com/apache/doris/pull/30543#discussion_r1470955686
##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -246,7 +313,7 @@ Status ProcessHashTableProbe<JoinOpType,
Parent>::do_process(HashTableType& hash
template <int JoinOpType, typename Parent>
template <bool with_other_conjuncts>
Status ProcessHashTableProbe<JoinOpType, Parent>::do_mark_join_conjuncts(
Review Comment:
warning: function 'do_mark_join_conjuncts' has cognitive complexity of 56
(threshold 50) [readability-function-cognitive-complexity]
```cpp
_conjuncts>
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/join/process_hash_table_probe_impl.h:327:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
ck->rows();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:336:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
et_data();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:348:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
tched = -1;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:350:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
ucket_size;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:351:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
are_join) {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:354:** +1, nesting
level increased to 4
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:354:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:357:** +1, nesting
level increased to 5
```cpp
i] = false;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:360:** +1, nesting
level increased to 5
```cpp
_indexs[i];
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:366:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
}
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:370:** +1, nesting
level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:370:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/common/status.h:540:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:370:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
} else {
^
```
**be/src/common/status.h:542:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:377:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
er.data();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:381:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
ll = false;
^
```
**be/src/common/status.h:540:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:381:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
ll = false;
^
```
**be/src/common/status.h:542:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:387:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
ter.data();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:406:** +1
```cpp
_has_null =
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:407:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
_conjuncts;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:409:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
_indexs[i];
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:411:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
_indexs[i];
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:413:** +1
```cpp
[i] = true;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:417:** +1, nesting
level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:417:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:420:** +1, nesting
level increased to 3
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:420:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:420:** +1
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:428:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
}
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:430:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
mark column
^
```
</details>
##########
be/src/vec/exec/join/process_hash_table_probe_impl.h:
##########
@@ -370,8 +440,7 @@
template <int JoinOpType, typename Parent>
Status ProcessHashTableProbe<JoinOpType, Parent>::do_other_join_conjuncts(
Review Comment:
warning: function 'do_other_join_conjuncts' has cognitive complexity of 60
(threshold 50) [readability-function-cognitive-complexity]
```cpp
ame Parent>
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/join/process_hash_table_probe_impl.h:445:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
ck->rows();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:454:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
ll = false;
^
```
**be/src/common/status.h:540:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:454:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
ll = false;
^
```
**be/src/common/status.h:542:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:469:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
.data();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:476:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
re are any.
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:480:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
mn_ptr[i];
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:483:** +1, nesting
level increased to 3
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:485:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
}
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:490:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:491:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
unt; ++i) {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:494:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
mn_ptr[i]);
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:500:** +1, nesting
level increased to 1
```cpp
er_column);
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:506:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
().data();
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:509:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
indexs[i];
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:510:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
EMI_JOIN) {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:514:** +1, nesting
level increased to 4
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:517:** +1, nesting
level increased to 3
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:517:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:520:** +1, nesting
level increased to 4
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:521:** +5, including
nesting penalty of 4, nesting level increased to 5
```cpp
i] = false;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:529:** +1, nesting
level increased to 1
```cpp
er_column);
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:531:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
NTI_JOIN) {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:534:** +1, nesting
level increased to 1
```cpp
;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:536:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
r_size = 0;
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:543:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
0);
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:547:** +1, nesting
level increased to 1
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:547:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:552:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
;
^
```
**be/src/common/status.h:540:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/exec/join/process_hash_table_probe_impl.h:552:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
;
^
```
**be/src/common/status.h:542:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
