Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-12 Thread via GitHub
HappenLee merged PR #36110: URL: https://github.com/apache/doris/pull/36110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-12 Thread via GitHub
github-actions[bot] commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2162673815 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-12 Thread via GitHub
github-actions[bot] commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2162673735 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
Mryange commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634545320 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) = unpac

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
zhiqiang- commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634530049 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) =

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
Mryange commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634526250 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) = unpac

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
zhiqiang- commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634521964 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) =

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
Mryange commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634517843 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) = unpac

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
Mryange commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634517843 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) = unpac

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
zhiqiang- commented on code in PR #36110: URL: https://github.com/apache/doris/pull/36110#discussion_r1634496441 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl { std::tie(col_right, format_const) =

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
doris-robot commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2160084724 ClickBench: Total hot run time: 29.78 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
doris-robot commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2160073279 TPC-DS: Total hot run time: 173761 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
doris-robot commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2160051368 TPC-H: Total hot run time: 39620 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
doris-robot commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2160021220 TeamCity be ut coverage result: Function Coverage: 36.43% (8984/24660) Line Coverage: 28.00% (73524/262559) Region Coverage: 27.40% (38087/139010) Branch Coverage: 24.0

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
github-actions[bot] commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2159996834 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
Mryange commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2159985639 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
doris-robot commented on PR #36110: URL: https://github.com/apache/doris/pull/36110#issuecomment-2159985334 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [fix](function) error scale set in unix_timestamp [doris]

2024-06-11 Thread via GitHub
Mryange opened a new pull request, #36110: URL: https://github.com/apache/doris/pull/36110 ## Proposed changes ``` mysql [test]>set DEBUG_SKIP_FOLD_CONSTANT = true; Query OK, 0 rows affected (0.00 sec) mysql [test]>select cast(unix_timestamp("2024-01-01",'-MM-dd') as