Mryange commented on code in PR #36110:
URL: https://github.com/apache/doris/pull/36110#discussion_r1634526250
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -702,7 +702,7 @@ struct UnixTimeStampStrImpl {
std::tie(col_right, format_const) =
unpack_if_const(block.get_by_position(arguments[1]).column);
- auto col_result = ColumnDecimal<Decimal64>::create(input_rows_count,
0);
+ auto col_result = ColumnDecimal<Decimal64>::create(input_rows_count,
6);
Review Comment:
> does FE have same assumption?
private static final List<FunctionSignature> SIGNATURES =
ImmutableList.of(
FunctionSignature.ret(IntegerType.INSTANCE).args(),
FunctionSignature.ret(DecimalV3Type.WILDCARD).args(DateTimeV2Type.SYSTEM_DEFAULT),
FunctionSignature.ret(IntegerType.INSTANCE).args(DateV2Type.INSTANCE),
FunctionSignature.ret(IntegerType.INSTANCE).args(DateTimeType.INSTANCE),
FunctionSignature.ret(IntegerType.INSTANCE).args(DateType.INSTANCE),
FunctionSignature.ret(DecimalV3Type.createDecimalV3Type(16,
6)).args(VarcharType.SYSTEM_DEFAULT,
VarcharType.SYSTEM_DEFAULT),
FunctionSignature.ret(DecimalV3Type.createDecimalV3Type(16,
6)).args(StringType.INSTANCE,
StringType.INSTANCE)
);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
