yiguolei merged PR #48554:
URL: https://github.com/apache/doris/pull/48554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apa
github-actions[bot] commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2696475568
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2696475495
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978701179
##
be/src/vec/columns/column_string.cpp:
##
@@ -649,8 +649,11 @@ void ColumnStr::compare_internal(size_t rhs_row_id,
const IColumn& rhs, int n
size_t end =
jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978709497
##
be/src/vec/columns/column_string.h:
##
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper> {
void insert_many_strings_without_reserve(const StringRe
jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978709497
##
be/src/vec/columns/column_string.h:
##
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper> {
void insert_many_strings_without_reserve(const StringRe
jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978697530
##
be/src/vec/columns/column_string.h:
##
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper> {
void insert_many_strings_without_reserve(const StringRe
yiguolei commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978685660
##
be/src/vec/columns/column_string.cpp:
##
@@ -649,8 +649,11 @@ void ColumnStr::compare_internal(size_t rhs_row_id,
const IColumn& rhs, int n
size_t end = s
yiguolei commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978689247
##
be/src/vec/columns/column_string.h:
##
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper> {
void insert_many_strings_without_reserve(const StringRef
jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978687819
##
be/src/vec/core/field.cpp:
##
@@ -174,14 +174,14 @@ DECLARE_DECIMAL_COMPARISON(Decimal256)
template <>
bool decimal_equal(Decimal128V3 x, Decimal128V3 y, UInt3
yiguolei commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978587260
##
be/src/vec/core/field.cpp:
##
@@ -174,14 +174,14 @@ DECLARE_DECIMAL_COMPARISON(Decimal256)
template <>
bool decimal_equal(Decimal128V3 x, Decimal128V3 y, UInt32
yiguolei commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978585716
##
be/src/vec/columns/column_string.h:
##
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper> {
void insert_many_strings_without_reserve(const StringRef
hello-stephen commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2696120209
# BE UT Coverage Report
Increment line coverage `22.22% (6/27)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/6337705bae20d4e17dbc60daa27b8672f
doris-robot commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2696092327
ClickBench: Total hot run time: 30.62 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2696087014
TPC-DS: Total hot run time: 192104 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2696068410
TPC-H: Total hot run time: 31900 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978499328
##
be/src/vec/columns/column_decimal.cpp:
##
@@ -100,12 +100,10 @@ void
ColumnDecimal::serialize_vec_with_null_map(StringRef* keys, size_t num_r
}
} el
zhiqiang- commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978496950
##
be/src/vec/columns/column_decimal.cpp:
##
@@ -100,12 +100,10 @@ void
ColumnDecimal::serialize_vec_with_null_map(StringRef* keys, size_t num_r
}
jacktengg commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2695953988
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2693879449
TPC-DS: Total hot run time: 185847 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
hello-stephen commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2693965381
# BE UT Coverage Report
Increment line coverage `22.22% (6/27)` :tada:
[Increment coverage
report](http://coverage.selectdb-in.cc/coverage/6337705bae20d4e17dbc60daa27b8672f
doris-robot commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2693896119
ClickBench: Total hot run time: 31.18 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2693850445
TPC-H: Total hot run time: 31807 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
jacktengg opened a new pull request, #48554:
URL: https://github.com/apache/doris/pull/48554
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Tes
hello-stephen commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2693624048
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro
jacktengg commented on PR #48554:
URL: https://github.com/apache/doris/pull/48554#issuecomment-2693624351
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
26 matches
Mail list logo
