zhiqiang-hhhh commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978496950
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -100,12 +100,10 @@ void
ColumnDecimal<T>::serialize_vec_with_null_map(StringRef* keys, size_t num_r
}
} else {
for (size_t i = 0; i < num_rows; ++i) {
- if (null_map[i] == 0) {
- char* __restrict dest = const_cast<char*>(keys[i].data +
+keys[i].size);
- memset(dest, 0, 1);
- memcpy_fixed<T>(dest + 1, (char*)&data[i]);
- keys[i].size += sizeof(T) + sizeof(UInt8);
- }
+ char* __restrict dest = const_cast<char*>(keys[i].data +
+keys[i].size);
Review Comment:
这里删除 if 是一个优化而不是逻辑fix？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
