Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-04-05 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750028035 TPC-DS: Total hot run time: 186698 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-04-05 Thread via GitHub
xzj7019 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011221334 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType targe

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-26 Thread via GitHub
morrySnow merged PR #49416: URL: https://github.com/apache/doris/pull/49416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
github-actions[bot] commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753346972 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753280834 ClickBench: Total hot run time: 30.96 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753274640 TPC-DS: Total hot run time: 193467 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753255582 TPC-H: Total hot run time: 34278 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
LiBinfeng-01 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753167194 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
LiBinfeng-01 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753131839 > does backend have different behavior to your fix? @LiBinfeng-01 > > for example: > > ```sql > set debug_skip_fold_constant=true; > select cast(1.0 as varchar(

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
924060929 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753118536 the backend have different behavior to your fix? @LiBinfeng-01 for example: ```sql set debug_skip_fold_constant=true; select cast(1.0 as varchar(4)); ``` the ba

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
924060929 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2753112988 can you test these case to check your fix? @LiBinfeng-01 ```sql set debug_skip_fold_constant=true; select cast(1.01 as varchar(7)); ``` the backend return the result:

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
924060929 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2013301879 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType tar

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
LiBinfeng-01 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2013291007 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
github-actions[bot] commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750845771 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
github-actions[bot] commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750845618 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750334295 TPC-DS: Total hot run time: 193312 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750346572 ClickBench: Total hot run time: 31.51 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-25 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750309680 TPC-H: Total hot run time: 33868 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
LiBinfeng-01 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750228276 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
LiBinfeng-01 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011410209 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
morrySnow commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011254894 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType tar

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750034052 ClickBench: Total hot run time: 30.87 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
morrySnow commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011265657 ## regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy: ## @@ -1723,5 +1723,13 @@ suite("fold_constant_string_arithmatic

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2750012570 TPC-H: Total hot run time: 35135 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
morrySnow commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011250900 ## regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy: ## @@ -1723,5 +1723,13 @@ suite("fold_constant_string_arithmatic

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
morrySnow commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011250900 ## regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy: ## @@ -1723,5 +1723,13 @@ suite("fold_constant_string_arithmatic

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
LiBinfeng-01 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2749990452 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
xzj7019 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011219471 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType targe

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
xzj7019 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011221334 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType targe

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
xzj7019 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2011218660 ## regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy: ## @@ -1723,5 +1723,10 @@ suite("fold_constant_string_arithmatic")

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2748130175 ClickBench: Total hot run time: 31.1 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2748114754 TPC-DS: Total hot run time: 193493 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
doris-robot commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2748078966 TPC-H: Total hot run time: 34064 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
LiBinfeng-01 commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2747965978 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
morrySnow commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2009935939 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType tar

Re: [PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
hello-stephen commented on PR #49416: URL: https://github.com/apache/doris/pull/49416#issuecomment-2747579410 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro

[PR] [fix](Nereids) fix double literal to string literal cast problem [doris]

2025-03-24 Thread via GitHub
LiBinfeng-01 opened a new pull request, #49416: URL: https://github.com/apache/doris/pull/49416 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note When cast double like 1.000 to string, it should