LiBinfeng-01 commented on code in PR #49416: URL: https://github.com/apache/doris/pull/49416#discussion_r2013291007
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java: ########## @@ -261,8 +261,14 @@ protected Expression uncheckedCastTo(DataType targetType) throws AnalysisExcepti return new CharLiteral(desc, ((CharType) targetType).getLen()); } } else if (targetType.isVarcharType()) { + if (this.dataType.isDoubleType() || this.dataType.isFloatType()) { Review Comment: branch-2.0 does not get into this code, after upgrade, two reason cause this problem together: - support substr fold constant by fe - https://github.com/apache/doris/pull/28959 remove getStringValue of DoubleLiteral and FloatLiteral -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org