Re: [PR] [feature](function)support url domain functions [doris]

2024-10-30 Thread via GitHub
zclllyybb commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1822084581 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CutToFirstSignificantSubdomain.java: ## @@ -0,0 +1,68 @@ +// Licensed to the A

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-30 Thread via GitHub
zhangstar333 merged PR #42488: URL: https://github.com/apache/doris/pull/42488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-30 Thread via GitHub
zhangstar333 commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1822214598 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CutToFirstSignificantSubdomain.java: ## @@ -0,0 +1,68 @@ +// Licensed to th

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2445694015 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-29 Thread via GitHub
github-actions[bot] commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2445694035 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-28 Thread via GitHub
zhangstar333 commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2443135699 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-28 Thread via GitHub
doris-robot commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2443232108 TeamCity be ut coverage result: Function Coverage: 37.40% (9718/25986) Line Coverage: 28.67% (80603/281107) Region Coverage: 28.11% (41674/148233) Branch Coverage: 24.6

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-28 Thread via GitHub
github-actions[bot] commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1820040164 ## be/src/vec/functions/url/find_symbols.h: ## @@ -0,0 +1,481 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-28 Thread via GitHub
zhangstar333 commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1820039424 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CutToFirstSignificantSubdomain.java: ## @@ -0,0 +1,68 @@ +// Licensed to th

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-28 Thread via GitHub
zhangstar333 commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1820038541 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_l

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-28 Thread via GitHub
morrySnow commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1818948417 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/CutToFirstSignificantSubdomain.java: ## @@ -0,0 +1,68 @@ +// Licensed to the A

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817873031 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817872772 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817872772 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1816470102 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817873603 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-26 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1817848401 ## be/src/vec/functions/url/find_symbols.h: ## @@ -0,0 +1,484 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreem

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2438255878 TeamCity be ut coverage result: Function Coverage: 37.42% (9716/25966) Line Coverage: 28.70% (80606/280875) Region Coverage: 28.13% (41668/148124) Branch Coverage: 24.7

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
zhangstar333 commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2438078173 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
HappenLee commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1816470102 ## be/src/vec/functions/url/domain.h: ## @@ -144,4 +145,138 @@ struct ExtractDomain { } }; +struct ExtractTopLevelDomain { +static size_t get_reserve_leng

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
github-actions[bot] commented on code in PR #42488: URL: https://github.com/apache/doris/pull/42488#discussion_r1816351779 ## be/src/vec/functions/url/find_symbols.h: ## @@ -0,0 +1,484 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor lice

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2437360394 TeamCity be ut coverage result: Function Coverage: 37.41% (9713/25964) Line Coverage: 28.68% (80572/280967) Region Coverage: 28.11% (41654/148156) Branch Coverage: 24.6

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
zhangstar333 commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2437301784 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
zhangstar333 commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2437262183 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
LiBinfeng-01 commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2437219936 need to add fe fold const when adding new scalar function to fe, which can refer to: https://selectdb.feishu.cn/wiki/BGfGwgY2uiQrK7krGUVcYJFknVg?from=from_copylink -- This is an a

Re: [PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
doris-robot commented on PR #42488: URL: https://github.com/apache/doris/pull/42488#issuecomment-2437211893 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [feature](function)support url domain functions [doris]

2024-10-25 Thread via GitHub
zhangstar333 opened a new pull request, #42488: URL: https://github.com/apache/doris/pull/42488 ## Proposed changes support top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain functions -- This is an automated message from the Apache Git