HappenLee commented on code in PR #42488:
URL: https://github.com/apache/doris/pull/42488#discussion_r1817872772
##########
be/src/vec/functions/url/domain.h:
##########
@@ -144,4 +145,138 @@ struct ExtractDomain {
}
};
+struct ExtractTopLevelDomain {
+ static size_t get_reserve_length_for_element() { return 5; }
+
+ static void execute(const char* data, size_t size, const char*& res_data,
size_t& res_size) {
+ StringRef host = get_url_host(data, size);
+
+ if (host.size == 0) {
+ res_data = data;
+ res_size = 0;
+ } else {
+ auto host_view = host.to_string_view();
+ if (host_view[host_view.size() - 1] == '.') {
+ host_view.remove_suffix(1);
+ }
+
+ const auto* host_end = host_view.data() + host_view.size();
+ const char* last_dot =
find_last_symbols_or_null<'.'>(host_view.data(), host_end);
+ if (!last_dot) {
Review Comment:
if not find the `last_dot` what should the `res_data` and `res_size` ?
DANGER ! it's may be UB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
