dataroaring merged PR #32681:
URL: https://github.com/apache/doris/pull/32681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.
github-actions[bot] commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2022026510
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2020138182
TeamCity be ut coverage result:
Function Coverage: 35.27% (8738/24777)
Line Coverage: 27.04% (71535/264516)
Region Coverage: 26.28% (37119/141219)
Branch Coverage: 23.1
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2020130729
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 1b4dce8152048de6680841c0e09352b836aa76fa with
default session variables
Stream
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2020125259
TPC-DS: Total hot run time: 181277 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2020103121
TPC-H: Total hot run time: 38132 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
wangshuo128 commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2020060272
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2019358832
TeamCity be ut coverage result:
Function Coverage: 35.27% (8738/24778)
Line Coverage: 27.05% (71559/264535)
Region Coverage: 26.28% (37114/141202)
Branch Coverage: 23.1
wangshuo128 commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2019295129
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017501714
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017479742
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 543505ddda22b95ad389d4ddce20ef423133deb8 with
default session variables
Stream
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017474964
TPC-DS: Total hot run time: 184393 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017465206
TeamCity be ut coverage result:
Function Coverage: 35.26% (8733/24770)
Line Coverage: 27.06% (71523/264355)
Region Coverage: 26.29% (37110/141132)
Branch Coverage: 23.1
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017457019
TPC-H: Total hot run time: 38335 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
wangshuo128 commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017423656
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017365383
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 99a508d3140668dbab5ee8b33cffcac0873bc215 with
default session variables
Stream
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017361494
TPC-DS: Total hot run time: 186654 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017347444
TPC-H: Total hot run time: 37737 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017337730
TeamCity be ut coverage result:
Function Coverage: 35.25% (8732/24770)
Line Coverage: 27.06% (71522/264346)
Region Coverage: 26.29% (37109/141128)
Branch Coverage: 23.1
wangshuo128 commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017310658
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017137301
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 99a508d3140668dbab5ee8b33cffcac0873bc215 with
default session variables
Stream
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017135175
TPC-DS: Total hot run time: 186334 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017126533
TPC-H: Total hot run time: 37834 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017118179
TeamCity be ut coverage result:
Function Coverage: 35.26% (8733/24770)
Line Coverage: 27.06% (71523/264342)
Region Coverage: 26.29% (37101/141125)
Branch Coverage: 23.1
wangshuo128 commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2017095422
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535480884
##
be/src/cloud/cloud_meta_mgr.cpp:
##
@@ -801,8 +801,7 @@ Status CloudMetaMgr::precommit_txn(const StreamLoadContext&
ctx) {
return retry_rpc("precom
platoneko commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535283875
##
be/src/cloud/cloud_meta_mgr.cpp:
##
@@ -826,18 +826,7 @@ Status CloudMetaMgr::get_storage_vault_info(
});
}
for (const
wangshuo128 commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535280564
##
be/src/util/vault_info_util.cpp:
##
Review Comment:
After checking, `recycler` and `BE` are different projects...
moving this to cloud_storage_engin.cpp.
wangshuo128 commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535276713
##
be/src/util/vault_info_util.cpp:
##
Review Comment:
I think this converting logic should also be used by `recycler`.
--
This is an automated message fro
gavinchou commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535269407
##
be/src/util/vault_info_util.cpp:
##
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
github-actions[bot] commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535248847
##
be/src/util/vault_info_util.h:
##
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
wangshuo128 opened a new pull request, #32681:
URL: https://github.com/apache/doris/pull/32681
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mai
doris-robot commented on PR #32681:
URL: https://github.com/apache/doris/pull/32681#issuecomment-2014629614
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
33 matches
Mail list logo
