github-actions[bot] commented on code in PR #32681:
URL: https://github.com/apache/doris/pull/32681#discussion_r1535480884
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -801,8 +801,7 @@ Status CloudMetaMgr::precommit_txn(const StreamLoadContext&
ctx) {
return retry_rpc("precommit txn", req, &res,
&MetaService_Stub::precommit_txn);
}
-Status CloudMetaMgr::get_storage_vault_info(
- std::vector<std::tuple<std::string, std::variant<S3Conf,
THdfsParams>>>* vault_infos) {
+Status CloudMetaMgr::get_storage_vault_info(StorageVaultInfos* vault_infos) {
Review Comment:
warning: method 'get_storage_vault_info' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status CloudMetaMgr::get_storage_vault_info(StorageVaultInfos*
vault_infos) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
