Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-15 Thread via GitHub
morrySnow merged PR #46905: URL: https://github.com/apache/doris/pull/46905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-14 Thread via GitHub
yujun777 commented on code in PR #46905: URL: https://github.com/apache/doris/pull/46905#discussion_r1916020928 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifySelfComparison.java: ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Founda

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-14 Thread via GitHub
github-actions[bot] commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2591764801 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-14 Thread via GitHub
englefly commented on code in PR #46905: URL: https://github.com/apache/doris/pull/46905#discussion_r1914377881 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifySelfComparison.java: ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Founda

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
englefly commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-251872 > > a + b >= a + b => TRUE 也可以是null吧,比如a是null > > yes, this pr desc is just for simple. In code, it will considering nullable, the code use `trueOrNull(a+b)`. it is better t

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
yujun777 commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2588870271 > a + b >= a + b => TRUE 也可以是null吧,比如a是null yes, this pr desc is just for simple. In code, it will considering nullable, the code use `trueOrNull(a+b)`. -- This is an automat

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
englefly commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2588861198 a + b >= a + b => TRUE 也可以是null吧,比如a是null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
yujun777 commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2587081835 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
yujun777 commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2586994845 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
doris-robot commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2586919365 ClickBench: Total hot run time: 30.91 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
doris-robot commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2586908495 TPC-DS: Total hot run time: 188640 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
doris-robot commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2586885055 TPC-H: Total hot run time: 32495 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feat](nereids) simplify self comparison [doris]

2025-01-13 Thread via GitHub
yujun777 commented on PR #46905: URL: https://github.com/apache/doris/pull/46905#issuecomment-2586847209 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns