yujun777 commented on code in PR #46905: URL: https://github.com/apache/doris/pull/46905#discussion_r1916020928
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/SimplifySelfComparison.java: ########## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.expression.rules; + +import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; +import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; +import org.apache.doris.nereids.rules.expression.ExpressionRuleType; +import org.apache.doris.nereids.trees.expressions.ComparisonPredicate; +import org.apache.doris.nereids.trees.expressions.EqualTo; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.GreaterThan; +import org.apache.doris.nereids.trees.expressions.GreaterThanEqual; +import org.apache.doris.nereids.trees.expressions.LessThan; +import org.apache.doris.nereids.trees.expressions.LessThanEqual; +import org.apache.doris.nereids.trees.expressions.NullSafeEqual; +import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral; +import org.apache.doris.nereids.util.ExpressionUtils; + +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * simplify with self comparison + * such as: a = a --> TRUE + * a + b > a + b --> FALSE + */ +public class SimplifySelfComparison implements ExpressionPatternRuleFactory { + public static SimplifySelfComparison INSTANCE = new SimplifySelfComparison(); + + @Override + public List<ExpressionPatternMatcher<? extends Expression>> buildRules() { + return ImmutableList.of( + matchesType(ComparisonPredicate.class) + .then(this::rewrite) + .toRule(ExpressionRuleType.SIMPLIFY_SELF_COMPARISON) + ); + } + + private Expression rewrite(ComparisonPredicate comparison) { + Expression left = comparison.left(); + if (left.equals(comparison.right())) { + if (comparison instanceof EqualTo + || comparison instanceof GreaterThanEqual + || comparison instanceof LessThanEqual) { + return ExpressionUtils.trueOrNull(left); + } + if (comparison instanceof NullSafeEqual) { + return BooleanLiteral.TRUE; + } + if (comparison instanceof GreaterThan || comparison instanceof LessThan) { + return ExpressionUtils.falseOrNull(left); + } + } + Review Comment: simplify `e = null`, `e is null` need use a new simplify null rule, it need to extract the slots from e, like: (a + b) is null => a is null or b is null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
