Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-12 Thread via GitHub
eldenmoon merged PR #37640: URL: https://github.com/apache/doris/pull/37640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-11 Thread via GitHub
github-actions[bot] commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2224344039 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-11 Thread via GitHub
github-actions[bot] commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2224344019 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-125440 ClickBench: Total hot run time: 30.33 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-118600 TPC-DS: Total hot run time: 175054 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-104744 TPC-H: Total hot run time: 40288 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
eldenmoon commented on code in PR #37640: URL: https://github.com/apache/doris/pull/37640#discussion_r1673404218 ## be/src/vec/columns/column_object.cpp: ## @@ -1552,9 +1552,11 @@ void ColumnObject::update_hash_with_value(size_t n, SipHash& hash) const { } for_each_im

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
eldenmoon commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-038827 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
yiguolei commented on code in PR #37640: URL: https://github.com/apache/doris/pull/37640#discussion_r1673389581 ## be/src/vec/columns/column_object.cpp: ## @@ -1552,9 +1552,11 @@ void ColumnObject::update_hash_with_value(size_t n, SipHash& hash) const { } for_each_imu

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2221975307 ClickBench: Total hot run time: 30.39 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2221969512 TPC-DS: Total hot run time: 174085 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2221960041 TPC-H: Total hot run time: 40438 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
eldenmoon commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2221903888 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
doris-robot commented on PR #37640: URL: https://github.com/apache/doris/pull/37640#issuecomment-2221903770 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [Refactor](Variant) make many insterfaces exception safe [doris]

2024-07-10 Thread via GitHub
eldenmoon opened a new pull request, #37640: URL: https://github.com/apache/doris/pull/37640 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a