yiguolei commented on code in PR #37640:
URL: https://github.com/apache/doris/pull/37640#discussion_r1673389581
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1552,9 +1552,11 @@ void ColumnObject::update_hash_with_value(size_t n,
SipHash& hash) const {
}
for_each_imutable_subcolumn([&](const auto& subcolumn) {
if (n >= subcolumn.size()) {
- LOG(FATAL) << n << " greater than column size " << subcolumn.size()
- << " sub_column_info:" << subcolumn.dump_structure()
- << " total lines of this column " << num_rows;
+ std::stringstream ss;
+ ss << n << " greater than column size " << subcolumn.size()
+ << " sub_column_info:" << subcolumn.dump_structure()
+ << " total lines of this column " << num_rows;
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR, ss.str());
Review Comment:
exception 接口有格式化string的功能，比如 throw
doris::Exception(ErrorCode::INTERNAL_ERROR, “afaf {}”, 123); 可以这么写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
