Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
HappenLee merged PR #36281: URL: https://github.com/apache/doris/pull/36281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
github-actions[bot] commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167816559 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
github-actions[bot] commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167816606 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167484202 ClickBench: Total hot run time: 30.7 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167473777 TPC-DS: Total hot run time: 174760 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167446411 TPC-H: Total hot run time: 39924 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167402221 TeamCity be ut coverage result: Function Coverage: 36.48% (8998/24667) Line Coverage: 28.03% (73704/262928) Region Coverage: 27.51% (38296/139205) Branch Coverage: 24.2

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
github-actions[bot] commented on code in PR #36281: URL: https://github.com/apache/doris/pull/36281#discussion_r1639371507 ## be/src/vec/aggregate_functions/aggregate_function_min_max.h: ## @@ -436,41 +432,43 @@ struct SingleValueDataString { } } -bool change

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-14 Thread via GitHub
HappenLee commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2167370050 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166273550 ClickBench: Total hot run time: 30.29 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166197756 TPC-H: Total hot run time: 40412 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
HappenLee commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166065438 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166158069 TeamCity be ut coverage result: Function Coverage: 36.45% (8991/24664) Line Coverage: 28.03% (73680/262899) Region Coverage: 27.50% (38277/139175) Branch Coverage: 24.1

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166243503 TPC-DS: Total hot run time: 174149 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
HappenLee commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166079197 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
HappenLee opened a new pull request, #36281: URL: https://github.com/apache/doris/pull/36281 ## Proposed changes Before ``` min max cost:800ms ``` After: ``` cost:105ms ``` -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
github-actions[bot] commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166078631 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Performance](exec) SIMD the min/max aggregate function [doris]

2024-06-13 Thread via GitHub
doris-robot commented on PR #36281: URL: https://github.com/apache/doris/pull/36281#issuecomment-2166065185 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y